Issue 14413004: Merge 195393 "Two fixes for the limited install from webstore flag."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14413004: Merge 195393 "Two fixes for the limited install from webstore flag." (Closed)

Created:
7 years, 8 months ago by levin

Modified:
7 years, 8 months ago

Reviewers:
levin

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1453/src/

Visibility:
Public.

More Reviews

Description

Merge 195393 "Two fixes for the limited install from webstore flag." > Two fixes for the limited install from webstore flag. > > 1. Add the resource to chrome.exe so that omaha can use it for app commands. > 2. Make extension install not prompt because the window launches behind the > current window (along with other problems) which results in a bad user experience. > > Note that the only code path touched is strictly only hit by the limited install from > webstore code path. > > > TESTED=The unit test and tested the functionality using a test page which calls the app command. > BUG=233783 > > Review URL: https://chromiumcodereview.appspot.com/14381004 TBR=levin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195577

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -17 lines)			Patch
M	chrome/app/chrome_exe.rc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/startup_helper.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/webstore_startup_installer_browsertest.cc	View	2 chunks	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r195577.

Expand Messages | Collapse Messages