Two fixes for the limited install from webstore flag.

Two fixes for the limited install from webstore flag.

1. Add the resource to chrome.exe so that omaha can use it for app commands.
2. Make extension install not prompt because the window launches behind the
current window (along with other problems) which results in a bad user experience.

Note that the only code path touched is strictly only hit by the limited install from
webstore code path.


TESTED=The unit test and tested the functionality using a test page which calls the app command.
BUG=233783
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195393

[levin, 2013-04-19 22:34:48]

cpu for the resource change (which is the same as two other instances:
https://code.google.com/p/chromium/codesearch#search/&q=IDR_GOOGLE_UPDATE_APP...
)

mpcomplete for the rest.

[Matt Perry, 2013-04-19 22:46:40]

LGTM

Is there a BUG for this?

[levin, 2013-04-19 22:55:47]

On 2013/04/19 22:46:40, Matt Perry wrote:
> LGTM
> 
> Is there a BUG for this?

Now there is! Thanks.

[levin, 2013-04-19 23:52:12]

Replaced cpu with someone who is available today. :)

[James Hawkins, 2013-04-19 23:53:23]

https://codereview.chromium.org/14381004/diff/1/chrome/browser/extensions/web...
File chrome/browser/extensions/webstore_startup_installer_browsertest.cc (left):

https://codereview.chromium.org/14381004/diff/1/chrome/browser/extensions/web...
chrome/browser/extensions/webstore_startup_installer_browsertest.cc:367:
IN_PROC_BROWSER_TEST_F(CommandLineWebstoreInstall, LimitedCancel) {
Is there any test that needs to be added?

[levin, 2013-04-20 00:00:59]

On 2013/04/19 23:53:23, James Hawkins wrote:
>
https://codereview.chromium.org/14381004/diff/1/chrome/browser/extensions/web...
> File chrome/browser/extensions/webstore_startup_installer_browsertest.cc
(left):
> 
>
https://codereview.chromium.org/14381004/diff/1/chrome/browser/extensions/web...
> chrome/browser/extensions/webstore_startup_installer_browsertest.cc:367:
> IN_PROC_BROWSER_TEST_F(CommandLineWebstoreInstall, LimitedCancel) {
> Is there any test that needs to be added?

No.

This test doesn't apply any more and removing the switch
switches::kAppsGalleryInstallAutoConfirmForTests from the other test does check
the change.

The only thing not tested is that this resource actually exists in chrome.exe I
didn't see tests for the existence of IDR_GOOGLE_UPDATE_APP_COMMANDS_MARKUP in
the other similar files.

[James Hawkins, 2013-04-20 00:01:32]

Thanks, LGTM.

[commit-bot: I haz the power, 2013-04-20 00:05:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/levin@chromium.org/14381004/1

[commit-bot: I haz the power, 2013-04-20 00:47:23]

Retried try job too often on linux_rel for step(s) interactive_ui_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-04-20 01:01:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/levin@chromium.org/14381004/1

[commit-bot: I haz the power, 2013-04-20 02:17:28]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win7_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-20 02:40:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/levin@chromium.org/14381004/1

[commit-bot: I haz the power, 2013-04-20 02:49:40]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win7_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-20 03:06:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/levin@chromium.org/14381004/1

[commit-bot: I haz the power, 2013-04-20 03:16:39]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win7_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-20 03:38:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/levin@chromium.org/14381004/1

[commit-bot: I haz the power, 2013-04-20 03:49:05]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win7_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-20 05:15:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/levin@chromium.org/14381004/1

[commit-bot: I haz the power, 2013-04-20 05:23:34]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win7_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-20 06:31:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/levin@chromium.org/14381004/1

[commit-bot: I haz the power, 2013-04-20 12:59:17]

Change committed as 195393