Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 14401013: Delete MacVDA from the codebase since it is dead code and not being worked on. (Closed)

Created:
7 years, 8 months ago by Ami GONE FROM CHROMIUM
Modified:
7 years, 8 months ago
CC:
chromium-reviews, jam, sail+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, apatrick_chromium, sail
Visibility:
Public.

Description

Delete MacVDA from the codebase since it is dead code and not being worked on. http://crbug.com/133828#c36 summarizes why this wasn't turned on. Also related: http://openradar.appspot.com/radar?id=1845403 BUG=133828 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196621

Patch Set 1 #

Patch Set 2 : fix mac build breakage #

Patch Set 3 : Remove pointless flag from linux & mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1549 lines) Patch
M chrome/browser/about_flags.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D content/common/gpu/media/avc_config_record_builder.h View 1 chunk +0 lines, -66 lines 0 comments Download
D content/common/gpu/media/avc_config_record_builder.cc View 1 chunk +0 lines, -155 lines 0 comments Download
D content/common/gpu/media/avc_config_record_builder_unittest.cc View 1 chunk +0 lines, -92 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 2 chunks +0 lines, -8 lines 0 comments Download
D content/common/gpu/media/mac_video_decode_accelerator.h View 1 chunk +0 lines, -137 lines 0 comments Download
D content/common/gpu/media/mac_video_decode_accelerator.mm View 1 chunk +0 lines, -390 lines 0 comments Download
D content/common/gpu/media/rendering_helper_mac.mm View 1 1 chunk +0 lines, -222 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 5 chunks +0 lines, -16 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 1 5 chunks +2 lines, -9 lines 0 comments Download
D ui/gfx/video_decode_acceleration_support_mac.h View 1 chunk +0 lines, -92 lines 0 comments Download
D ui/gfx/video_decode_acceleration_support_mac.mm View 1 chunk +0 lines, -224 lines 0 comments Download
D ui/gfx/video_decode_acceleration_support_mac_unittest.mm View 1 chunk +0 lines, -130 lines 0 comments Download
M ui/ui.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/ui_unittests.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Ami GONE FROM CHROMIUM
scherkus: please review sail: FYI and :'(
7 years, 8 months ago (2013-04-25 18:30:19 UTC) #1
Ami GONE FROM CHROMIUM
thakis: please OWNERS for ui/ jam: please OWNERS for content/*gypi Thanks!
7 years, 8 months ago (2013-04-25 19:17:43 UTC) #2
Nico
Can you say in the CL description why this isn't used (iirc it turned out ...
7 years, 8 months ago (2013-04-25 19:30:36 UTC) #3
Ami GONE FROM CHROMIUM
On Thu, Apr 25, 2013 at 12:30 PM, <thakis@chromium.org> wrote: > Can you say in ...
7 years, 8 months ago (2013-04-25 19:55:42 UTC) #4
scherkus (not reviewing)
LGTM WDYT about modifying the kOsDesktop value for disable-accelerated-video-decode so that flag doesn't show up ...
7 years, 8 months ago (2013-04-25 20:14:57 UTC) #5
Nico
lgtm
7 years, 8 months ago (2013-04-25 20:24:13 UTC) #6
Ami GONE FROM CHROMIUM
On Thu, Apr 25, 2013 at 1:14 PM, <scherkus@chromium.org> wrote: > WDYT about modifying the ...
7 years, 8 months ago (2013-04-25 20:37:09 UTC) #7
scherkus (not reviewing)
LGTM++
7 years, 8 months ago (2013-04-25 20:47:26 UTC) #8
jam
lgtm
7 years, 8 months ago (2013-04-25 23:46:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/14401013/11002
7 years, 8 months ago (2013-04-26 00:43:22 UTC) #10
commit-bot: I haz the power
7 years, 8 months ago (2013-04-26 05:14:21 UTC) #11
Message was sent while issue was closed.
Change committed as 196621

Powered by Google App Engine
This is Rietveld 408576698