Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 14348007: Reland: Remove reference counting from media::VideoDecoder and friends. (Closed)

Created:
7 years, 8 months ago by scherkus (not reviewing)
Modified:
7 years, 8 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Reland: Remove reference counting from media::VideoDecoder and friends. In addition: * VideoRenderer is now passed a list of decoders via constructor instead of Initialize() * WebMediaPlayerImpl's FilterCollection is now built in one shot instead of incrementally BUG=173313 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195212

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+463 lines, -474 lines) Patch
M media/base/filter_collection.h View 4 chunks +0 lines, -8 lines 0 comments Download
M media/base/filter_collection.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M media/base/mock_filters.h View 1 chunk +9 lines, -10 lines 0 comments Download
M media/base/pipeline.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M media/base/pipeline_unittest.cc View 5 chunks +9 lines, -18 lines 0 comments Download
M media/base/video_decoder.h View 3 chunks +5 lines, -7 lines 0 comments Download
M media/base/video_renderer.h View 4 chunks +2 lines, -7 lines 0 comments Download
M media/filters/decrypting_video_decoder.h View 4 chunks +4 lines, -4 lines 0 comments Download
M media/filters/decrypting_video_decoder.cc View 8 chunks +8 lines, -6 lines 0 comments Download
M media/filters/decrypting_video_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 4 chunks +4 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 3 chunks +4 lines, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M media/filters/gpu_video_decoder.h View 6 chunks +14 lines, -5 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 18 chunks +156 lines, -68 lines 0 comments Download
M media/filters/pipeline_integration_test_base.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M media/filters/video_decoder_selector.h View 4 chunks +10 lines, -10 lines 0 comments Download
M media/filters/video_decoder_selector.cc View 5 chunks +36 lines, -43 lines 0 comments Download
M media/filters/video_decoder_selector_unittest.cc View 12 chunks +26 lines, -30 lines 0 comments Download
M media/filters/video_frame_stream.h View 1 2 4 chunks +9 lines, -8 lines 0 comments Download
M media/filters/video_frame_stream.cc View 1 7 chunks +15 lines, -16 lines 0 comments Download
M media/filters/video_frame_stream_unittest.cc View 1 5 chunks +19 lines, -12 lines 0 comments Download
M media/filters/video_renderer_base.h View 5 chunks +9 lines, -1 line 0 comments Download
M media/filters/video_renderer_base.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M media/filters/video_renderer_base_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M media/filters/vpx_video_decoder.h View 4 chunks +4 lines, -4 lines 0 comments Download
M media/filters/vpx_video_decoder.cc View 3 chunks +3 lines, -1 line 0 comments Download
M media/tools/player_x11/player_x11.cc View 1 chunk +4 lines, -3 lines 0 comments Download
D webkit/media/filter_helpers.h View 1 chunk +0 lines, -49 lines 0 comments Download
D webkit/media/filter_helpers.cc View 1 chunk +0 lines, -81 lines 0 comments Download
M webkit/media/webkit_media.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/media/webmediaplayer_impl.h View 4 chunks +7 lines, -3 lines 0 comments Download
M webkit/media/webmediaplayer_impl.cc View 11 chunks +88 lines, -46 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scherkus (not reviewing)
PTAL PS#1 is the original CL. PS#2 contains the fix.
7 years, 8 months ago (2013-04-18 22:41:42 UTC) #1
xhwang
lgtm
7 years, 8 months ago (2013-04-18 22:56:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/14348007/14001
7 years, 8 months ago (2013-04-19 00:58:20 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 15:28:36 UTC) #4
Message was sent while issue was closed.
Change committed as 195212

Powered by Google App Engine
This is Rietveld 408576698