Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Unified Diff: media/filters/video_frame_stream.h

Issue 14348007: Reland: Remove reference counting from media::VideoDecoder and friends. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/video_decoder_selector_unittest.cc ('k') | media/filters/video_frame_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/video_frame_stream.h
diff --git a/media/filters/video_frame_stream.h b/media/filters/video_frame_stream.h
index f81541940b56e8c1939a35bf63f7b51a007f39c4..10956c6dce5251f55ba6733dde375c427f37a009 100644
--- a/media/filters/video_frame_stream.h
+++ b/media/filters/video_frame_stream.h
@@ -11,12 +11,14 @@
#include "base/callback.h"
#include "base/compiler_specific.h"
#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_vector.h"
#include "base/memory/weak_ptr.h"
#include "media/base/decryptor.h"
#include "media/base/demuxer_stream.h"
#include "media/base/media_export.h"
#include "media/base/pipeline_status.h"
#include "media/base/video_decoder.h"
+#include "media/filters/video_decoder_selector.h"
namespace base {
class MessageLoopProxy;
@@ -31,18 +33,16 @@ class VideoDecoderSelector;
// VideoFrames to its client (e.g. VideoRendererBase).
class MEDIA_EXPORT VideoFrameStream : public DemuxerStream {
public:
- typedef std::list<scoped_refptr<VideoDecoder> > VideoDecoderList;
-
// Indicates completion of VideoFrameStream initialization.
typedef base::Callback<void(bool success, bool has_alpha)> InitCB;
VideoFrameStream(const scoped_refptr<base::MessageLoopProxy>& message_loop,
+ ScopedVector<VideoDecoder> decoders,
const SetDecryptorReadyCB& set_decryptor_ready_cb);
// Initializes the VideoFrameStream and returns the initialization result
// through |init_cb|. Note that |init_cb| is always called asynchronously.
void Initialize(const scoped_refptr<DemuxerStream>& stream,
- const VideoDecoderList& decoders,
const StatisticsCB& statistics_cb,
const InitCB& init_cb);
@@ -87,14 +87,12 @@ class MEDIA_EXPORT VideoFrameStream : public DemuxerStream {
STOPPED
};
- // Called when |decoder_selector_| selected the |selected_decoder|.
+ // Called when |decoder_selector| selected the |selected_decoder|.
// |decrypting_demuxer_stream| was also populated if a DecryptingDemuxerStream
// is created to help decrypt the encrypted stream.
- // Note: |decoder_selector| is passed here to keep the VideoDecoderSelector
- // alive until OnDecoderSelected() finishes.
void OnDecoderSelected(
scoped_ptr<VideoDecoderSelector> decoder_selector,
- const scoped_refptr<VideoDecoder>& selected_decoder,
+ scoped_ptr<VideoDecoder> selected_decoder,
const scoped_refptr<DecryptingDemuxerStream>& decrypting_demuxer_stream);
// Callback for VideoDecoder::Read().
@@ -118,12 +116,15 @@ class MEDIA_EXPORT VideoFrameStream : public DemuxerStream {
base::Closure reset_cb_;
base::Closure stop_cb_;
+ // TODO(scherkus): Replace these with a VideoDecoderSelector instance after
+ // DemuxerStream is no longer refcounted.
+ ScopedVector<VideoDecoder> decoders_;
SetDecryptorReadyCB set_decryptor_ready_cb_;
scoped_refptr<DemuxerStream> stream_;
// These two will be set by VideoDecoderSelector::SelectVideoDecoder().
- scoped_refptr<VideoDecoder> decoder_;
+ scoped_ptr<VideoDecoder> decoder_;
scoped_refptr<DecryptingDemuxerStream> decrypting_demuxer_stream_;
DISALLOW_COPY_AND_ASSIGN(VideoFrameStream);
« no previous file with comments | « media/filters/video_decoder_selector_unittest.cc ('k') | media/filters/video_frame_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698