Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1302)

Unified Diff: media/tools/player_x11/player_x11.cc

Issue 14348007: Reland: Remove reference counting from media::VideoDecoder and friends. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/vpx_video_decoder.cc ('k') | webkit/media/filter_helpers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/tools/player_x11/player_x11.cc
diff --git a/media/tools/player_x11/player_x11.cc b/media/tools/player_x11/player_x11.cc
index e9254e1799ee1d38269bf989874e596114b5c23c..7b029fcc0d1f4fcf30a2a75f8a11cf9981c322d1 100644
--- a/media/tools/player_x11/player_x11.cc
+++ b/media/tools/player_x11/player_x11.cc
@@ -113,12 +113,13 @@ bool InitPipeline(const scoped_refptr<base::MessageLoopProxy>& message_loop,
media::FFmpegNeedKeyCB need_key_cb = base::Bind(&NeedKey);
collection->SetDemuxer(new media::FFmpegDemuxer(message_loop, data_source,
need_key_cb));
- collection->GetVideoDecoders()->push_back(new media::FFmpegVideoDecoder(
- message_loop));
- // Create our video renderer and save a reference to it for painting.
+
+ ScopedVector<media::VideoDecoder> video_decoders;
+ video_decoders.push_back(new media::FFmpegVideoDecoder(message_loop));
scoped_ptr<media::VideoRenderer> video_renderer(new media::VideoRendererBase(
message_loop,
+ video_decoders.Pass(),
media::SetDecryptorReadyCB(),
base::Bind(&Paint, paint_message_loop, paint_cb),
base::Bind(&SetOpaque),
« no previous file with comments | « media/filters/vpx_video_decoder.cc ('k') | webkit/media/filter_helpers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698