Remove unused |first_run| parameter in ImporterHost::CheckForFirefoxLock() which results in a casca…

Remove unused |first_run| parameter in ImporterHost::CheckForFirefoxLock() which results in a cascade of unused parameter removal.

This is a precursor CL to https://codereview.chromium.org/12670013/

TBR=ben@chromium.org
BUG=219419
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196209

[gab, 2013-04-17 03:25:56]

Carlos, please take a look.

I'm not sure the pyauto tests for import are still relevant at all (especially
after all the new tests I will introduce with
https://codereview.chromium.org/12670013/)... do you know if these tests are
even ran?

Thanks!
Gab

[dennis_jeffrey, 2013-04-17 16:42:21]

On 2013/04/17 03:25:56, gab wrote:
> Carlos, please take a look.
> 
> I'm not sure the pyauto tests for import are still relevant at all (especially
> after all the new tests I will introduce with
> https://codereview.chromium.org/12670013/)... do you know if these tests are
> even ran?
> 
> Thanks!
> Gab

From the PYAUTO_TESTS file it looks like the imports tests might still be run on
chrome, but kkania@ should know for sure.  We don't run them on chromeOS.

chrome/test/* LGTM

[cpu_(ooo_6.6-7.5), 2013-04-17 21:28:48]

true

[cpu_(ooo_6.6-7.5), 2013-04-17 21:29:34]

I meant lgtm

[gab, 2013-04-17 21:44:13]

Thanks,

@ben for OWNERS.

I'm happy to remove the pyauto tests for import if they're not used (looking at
them it doesn't feel they even test the current state of things...).

Gab

[gab, 2013-04-18 19:44:43]

Miranda, can you take a quick look at the chrome/browser/importer/* changes.

Thanks!
Gab

[Miranda Callahan, 2013-04-18 19:49:51]

On 2013/04/18 19:44:43, gab wrote:
> Miranda, can you take a quick look at the chrome/browser/importer/* changes.
> 
> Thanks!
> Gab

importer/* LGTM!

[gab, 2013-04-23 22:46:34]

TBR ben for side-effects outside of c/b/first_run and c/b/importer/.

Thanks!
Gab

[commit-bot: I haz the power, 2013-04-24 10:08:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/14316007/37001

[commit-bot: I haz the power, 2013-04-24 10:08:04]

Failed to apply patch for
chrome/browser/extensions/api/bookmarks/bookmarks_api.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
  Hunk #1 FAILED at 982.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/extensions/api/bookmarks/bookmarks_api.cc.rej

Patch:       chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
Index: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
diff --git a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
index
754eeeee4718495e6107b9028b94b8aa738f7235..495d8a0bc55fbf8db7debc06464e8694743fff76
100644
--- a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
+++ b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
@@ -982,8 +982,7 @@ void BookmarksImportFunction::FileSelected(const
base::FilePath& path,
   importer_host->StartImportSettings(source_profile,
                                      profile(),
                                      importer::FAVORITES,
-                                     new ProfileWriter(profile()),
-                                     true);
+                                     new ProfileWriter(profile()));
 #endif
   Release();  // Balanced in BookmarksIOFunction::SelectFile()
 }

[commit-bot: I haz the power, 2013-04-24 14:19:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/14316007/45001

[commit-bot: I haz the power, 2013-04-24 17:20:39]

Retried try job too often on win7_aura for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-04-24 17:22:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/14316007/45001

[commit-bot: I haz the power, 2013-04-24 19:54:39]

Change committed as 196209