chrome/browser/automation/testing_automation_provider.cc - Issue 14316007: Remove unused |first_run| parameter in ImporterHost::CheckForFirefoxLock() which results in a casca…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 14316007: Remove unused |first_run| parameter in ImporterHost::CheckForFirefoxLock() which results in a casca… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: merge up to r196136 Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/automation/testing_automation_provider.h ('k') | chrome/browser/extensions/api/bookmarks/bookmarks_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/automation/testing_automation_provider.cc

diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc

index 9a45b7c6937c27fdae8b58be773358a2988750eb..f2330a598d94b0c9f648532fcd39ba0ea51e820b 100644

--- a/chrome/browser/automation/testing_automation_provider.cc

+++ b/chrome/browser/automation/testing_automation_provider.cc

@@ -332,8 +332,7 @@ void TestingAutomationProvider::OnSourceProfilesLoaded() {

importer_host->StartImportSettings(source_profile,

target_profile,

import_settings_data_.import_items,

- new ProfileWriter(target_profile),

- import_settings_data_.first_run);

+ new ProfileWriter(target_profile));

}

void TestingAutomationProvider::Observe(

@@ -3265,7 +3264,6 @@ void TestingAutomationProvider::ImportSettings(Browser* browser,

ListValue* import_items_list = NULL;

if (!args->GetString("import_from", &import_settings_data_.browser_name) ||

- !args->GetBoolean("first_run", &import_settings_data_.first_run) ||

!args->GetList("import_items", &import_items_list)) {

AutomationJSONReply(this, reply_message)

.SendError("Incorrect type for one or more of the arguments.");