Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: chrome/test/pyautolib/pyauto.py

Issue 14316007: Remove unused |first_run| parameter in ImporterHost::CheckForFirefoxLock() which results in a casca… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge up to r196136 Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/functional/imports.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/pyautolib/pyauto.py
diff --git a/chrome/test/pyautolib/pyauto.py b/chrome/test/pyautolib/pyauto.py
index 32282a9984181386c68dc6448ee9651d88b27f1a..984c7a60c801849a90a64a161de56b5dff7c7e28 100755
--- a/chrome/test/pyautolib/pyauto.py
+++ b/chrome/test/pyautolib/pyauto.py
@@ -2992,8 +2992,7 @@ class PyUITest(pyautolib.PyUITestBase, unittest.TestCase):
finally:
shutil.rmtree(tempdir, ignore_errors=True)
- def ImportSettings(self, import_from, first_run,
- import_items, windex=0):
+ def ImportSettings(self, import_from, import_items, windex=0):
"""Import the specified import items from the specified browser.
Implements the features available in the "Import Settings" part of the
@@ -3004,12 +3003,6 @@ class PyUITest(pyautolib.PyUITestBase, unittest.TestCase):
strings (depending on which browsers are installed on the
machine) are: 'Mozilla Firefox', 'Google Toolbar',
'Microsoft Internet Explorer', 'Safari'
- first_run: A boolean indicating whether this is the first run of
- the browser.
- If it is not the first run then:
- 1) Bookmarks are only imported to the bookmarks bar if there
- aren't already bookmarks.
- 2) The bookmark bar is shown.
import_items: A list of strings indicating which items to import.
Strings that can be in the list are:
HISTORY, FAVORITES, PASSWORDS, SEARCH_ENGINES, HOME_PAGE,
@@ -3022,7 +3015,6 @@ class PyUITest(pyautolib.PyUITestBase, unittest.TestCase):
cmd_dict = { # Prepare command for the json interface
'command': 'ImportSettings',
'import_from': import_from,
- 'first_run': first_run,
'import_items': import_items
}
return self._GetResultFromJSONRequest(cmd_dict, windex=windex)
« no previous file with comments | « chrome/test/functional/imports.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698