chrome/android/java/res/layout/snackbar.xml - Issue 1430273002: [Smart Lock, UI] Add ability to have an icon to the SnanackBar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/snackbar.xml

Issue 1430273002: [Smart Lock, UI] Add ability to have an icon to the SnanackBar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/snackbar.xml

diff --git a/chrome/android/java/res/layout/snackbar.xml b/chrome/android/java/res/layout/snackbar.xml

index 119916007b5f9f69e16eb9e9089d439bc6cc50a6..68a3e10621e688e660c1f7b7f6ede000dcfaecd3 100644

--- a/chrome/android/java/res/layout/snackbar.xml

+++ b/chrome/android/java/res/layout/snackbar.xml

@@ -9,6 +9,13 @@

android:minHeight="@dimen/snackbar_min_height"

android:orientation="horizontal" >

+ <ImageView android:id="@+id/snackbar_icon"

+ android:layout_width="24dp"

gone 2015/11/10 00:35:04 nit: indentation is messed up

+ android:layout_height="24dp"

+ android:layout_gravity="center_vertical"

+ android:layout_marginStart="12dp"

gone 2015/11/10 00:35:04 can you explicitly state what ImageView.ScaleType

+ android:contentDescription="@null"/>

<org.chromium.chrome.browser.snackbar.TemplatePreservingTextView

android:id="@+id/snackbar_message"

android:layout_width="0dp"