Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3506)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java

Issue 1430273002: [Smart Lock, UI] Add ability to have an icon to the SnanackBar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java
index f4055dc59b2620e140843d156d996ae2a16e6661..e15bc65e9fdffe91f8a3c11d52e28abce75c06f4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/Snackbar.java
@@ -4,6 +4,8 @@
package org.chromium.chrome.browser.snackbar;
+import android.graphics.Bitmap;
+
import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;
/**
@@ -26,6 +28,7 @@ public class Snackbar {
private int mBackgroundColor;
private boolean mSingleLine = true;
private int mDurationMs;
+ private Bitmap mIcon;
// Prevent instantiation.
private Snackbar() {}
@@ -65,6 +68,14 @@ public class Snackbar {
}
/**
+ * Sets the icon which should be displayed in the snackbar. If null, snackbar will have no icon.
+ */
+ public Snackbar setIcon(Bitmap icon) {
gone 2015/11/10 00:35:04 The spec says that an "icon" only gets added for i
gone 2015/11/10 00:44:41 Also, could you make javadoc say explicitly that t
+ mIcon = icon;
+ return this;
+ }
+
+ /**
* Sets whether the snackbar text should be limited to a single line and ellipsized if needed.
*/
public Snackbar setSingleLine(boolean singleLine) {
@@ -123,4 +134,11 @@ public class Snackbar {
int getBackgroundColor() {
return mBackgroundColor;
}
+
+ /**
+ * If method returns null, then no icon will be shown in snackbar.
+ */
+ Bitmap getIcon() {
+ return mIcon;
+ }
}

Powered by Google App Engine
This is Rietveld 408576698