OLD | NEW |
---|---|
1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. |
3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
4 found in the LICENSE file. --> | 4 found in the LICENSE file. --> |
5 | 5 |
6 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | 6 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" |
7 android:layout_width="match_parent" | 7 android:layout_width="match_parent" |
8 android:layout_height="wrap_content" | 8 android:layout_height="wrap_content" |
9 android:minHeight="@dimen/snackbar_min_height" | 9 android:minHeight="@dimen/snackbar_min_height" |
10 android:orientation="horizontal" > | 10 android:orientation="horizontal" > |
11 | 11 |
12 <ImageView android:id="@+id/snackbar_icon" | |
13 android:layout_width="24dp" | |
gone
2015/11/10 00:35:04
nit: indentation is messed up
| |
14 android:layout_height="24dp" | |
15 android:layout_gravity="center_vertical" | |
16 android:layout_marginStart="12dp" | |
gone
2015/11/10 00:35:04
can you explicitly state what ImageView.ScaleType
| |
17 android:contentDescription="@null"/> | |
18 | |
12 <org.chromium.chrome.browser.snackbar.TemplatePreservingTextView | 19 <org.chromium.chrome.browser.snackbar.TemplatePreservingTextView |
13 android:id="@+id/snackbar_message" | 20 android:id="@+id/snackbar_message" |
14 android:layout_width="0dp" | 21 android:layout_width="0dp" |
15 android:layout_height="wrap_content" | 22 android:layout_height="wrap_content" |
16 android:layout_gravity="start|center_vertical" | 23 android:layout_gravity="start|center_vertical" |
17 android:layout_marginStart="24dp" | 24 android:layout_marginStart="24dp" |
18 android:layout_marginTop="14dp" | 25 android:layout_marginTop="14dp" |
19 android:layout_marginBottom="14dp" | 26 android:layout_marginBottom="14dp" |
20 android:layout_weight="1" | 27 android:layout_weight="1" |
21 android:textAlignment="viewStart" | 28 android:textAlignment="viewStart" |
22 android:textColor="@android:color/white" | 29 android:textColor="@android:color/white" |
23 android:textSize="14sp" /> | 30 android:textSize="14sp" /> |
24 | 31 |
25 <Button | 32 <Button |
26 android:id="@+id/snackbar_button" | 33 android:id="@+id/snackbar_button" |
27 android:layout_width="wrap_content" | 34 android:layout_width="wrap_content" |
28 android:layout_height="@dimen/snackbar_min_height" | 35 android:layout_height="@dimen/snackbar_min_height" |
29 android:layout_gravity="center_vertical" | 36 android:layout_gravity="center_vertical" |
30 android:paddingEnd="24dp" | 37 android:paddingEnd="24dp" |
31 android:paddingStart="24dp" | 38 android:paddingStart="24dp" |
32 android:fontFamily="sans-serif-medium" | 39 android:fontFamily="sans-serif-medium" |
33 android:textAllCaps="true" | 40 android:textAllCaps="true" |
34 android:textColor="@color/snackbar_button_color" | 41 android:textColor="@color/snackbar_button_color" |
35 android:textSize="14sp" | 42 android:textSize="14sp" |
36 style="@style/ButtonCompatBorderless" /> | 43 style="@style/ButtonCompatBorderless" /> |
37 | 44 |
38 </LinearLayout> | 45 </LinearLayout> |
OLD | NEW |