chrome/browser/search_engines/search_provider_install_data.cc - Issue 14299011: Remove all but one use of WeakPtrFactory::DetachFromThread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search_engines/search_provider_install_data.cc

Issue 14299011: Remove all but one use of WeakPtrFactory::DetachFromThread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove checks for death with correct error, which seem to fail on iOS Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/search_engines/search_provider_install_data.cc

diff --git a/chrome/browser/search_engines/search_provider_install_data.cc b/chrome/browser/search_engines/search_provider_install_data.cc

index af77e8f1e3a6b219de7d07fd7ec9be61a02c78eb..791a50134adf88706f1ceb050ca5a273bd69cc04 100644

--- a/chrome/browser/search_engines/search_provider_install_data.cc

+++ b/chrome/browser/search_engines/search_provider_install_data.cc

@@ -167,7 +167,6 @@ SearchProviderInstallData::SearchProviderInstallData(

// the given notification occurs.

new GoogleURLObserver(profile, new GoogleURLChangeNotifier(AsWeakPtr()),

ui_death_notification, ui_death_source);

- DetachFromThread();

}

SearchProviderInstallData::~SearchProviderInstallData() {