chrome/browser/plugins/plugin_info_message_filter.cc - Issue 14299011: Remove all but one use of WeakPtrFactory::DetachFromThread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugins/plugin_info_message_filter.cc

Issue 14299011: Remove all but one use of WeakPtrFactory::DetachFromThread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove checks for death with correct error, which seem to fail on iOS Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/plugins/plugin_info_message_filter.cc

diff --git a/chrome/browser/plugins/plugin_info_message_filter.cc b/chrome/browser/plugins/plugin_info_message_filter.cc

index a83f2037774e90ba4a38fad9c77897b0de8834fd..5e635d67c2be01dea2f017fd0c9a6aabcd5ca6c7 100644

--- a/chrome/browser/plugins/plugin_info_message_filter.cc

+++ b/chrome/browser/plugins/plugin_info_message_filter.cc

@@ -105,8 +105,6 @@ bool PluginInfoMessageFilter::OnMessageReceived(const IPC::Message& message,

void PluginInfoMessageFilter::OnDestruct() const {

const_cast<PluginInfoMessageFilter*>(this)->

- weak_ptr_factory_.DetachFromThread();

- const_cast<PluginInfoMessageFilter*>(this)->

weak_ptr_factory_.InvalidateWeakPtrs();

// Destroy on the UI thread because we contain a |PrefMember|.