net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc - Issue 14299011: Remove all but one use of WeakPtrFactory::DetachFromThread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc

Issue 14299011: Remove all but one use of WeakPtrFactory::DetachFromThread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove checks for death with correct error, which seem to fail on iOS Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc

diff --git a/net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc b/net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc

index 8a405a78d86ef423516c8fd0978833699fbc20d0..2b49b9430dbc4cf1b8986c5ac0fc2a5fe94f15ca 100644

--- a/net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc

+++ b/net/proxy/dhcp_proxy_script_adapter_fetcher_win.cc

@@ -41,11 +41,6 @@ DhcpProxyScriptAdapterFetcher::DhcpProxyScriptAdapterFetcher(

DhcpProxyScriptAdapterFetcher::~DhcpProxyScriptAdapterFetcher() {

Cancel();

- // The WeakPtr we passed to the worker thread may be destroyed on the

- // worker thread. This detaches any outstanding WeakPtr state from

- // the current thread.

- base::SupportsWeakPtr<DhcpProxyScriptAdapterFetcher>::DetachFromThread();

}

void DhcpProxyScriptAdapterFetcher::Fetch(