Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: chrome/browser/ui/tabs/pinned_tab_codec.cc

Issue 14241002: Move the parsing of app.launch related keys out of Extension class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tabs/pinned_tab_codec.cc
diff --git a/chrome/browser/ui/tabs/pinned_tab_codec.cc b/chrome/browser/ui/tabs/pinned_tab_codec.cc
index 35d4ff8d55a324b9b078f8a285ff7ddd92b8fb68..f27321183b8771c91659bc295bd0b5049aee8168 100644
--- a/chrome/browser/ui/tabs/pinned_tab_codec.cc
+++ b/chrome/browser/ui/tabs/pinned_tab_codec.cc
@@ -13,6 +13,7 @@
#include "chrome/browser/ui/browser_iterator.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/common/extensions/app_launcher_info.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/pref_names.h"
#include "components/user_prefs/pref_registry_syncable.h"
@@ -62,7 +63,8 @@ static void EncodePinnedTab(TabStripModel* model,
// For apps we use the launch url. We do this because the user is
// effectively restarting the app, so returning them to the app's launch
// page seems closest to what they expect.
- value->SetString(kURL, extension->GetFullLaunchURL().spec());
+ value->SetString(
+ kURL, extensions::AppLauncherInfo::GetFullLaunchURL(extension).spec());
values->Append(value.release());
} else {
NavigationEntry* entry = web_contents->GetController().GetActiveEntry();

Powered by Google App Engine
This is Rietveld 408576698