Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1423723006: Hard-code tap resolve and prefetch limits. (Closed)

Created:
5 years, 1 month ago by aurimas (slooooooooow)
Modified:
5 years, 1 month ago
Reviewers:
Theresa
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@tap_promo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hard-code tap resolve and prefetch limits. - TAP_RESOLVE_LIMIT_FOR_DECIDED and TAP_PREFETCH_LIMIT_FOR_DECIDED are always set to 50 via finch. - TAP_RESOLVE_LIMIT_FOR_UNDECIDED and TAP_PREFETCH_LIMIT_FOR_UNDECIDED are always set to 20 via finch. This CL hard-codes these values and allows for tests to overrride it. BUG=527621 Committed: https://crrev.com/b9eb2c66e29459a5ba5ade86181d40ec0fa3977f Cr-Commit-Position: refs/heads/master@{#358723}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Add @VisibleForTesting annotation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -107 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java View 1 3 chunks +0 lines, -74 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java View 1 2 6 chunks +54 lines, -24 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 1 6 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
aurimas (slooooooooow)
PTAL
5 years, 1 month ago (2015-11-09 22:41:33 UTC) #2
Theresa
lgtm
5 years, 1 month ago (2015-11-09 22:46:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423723006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423723006/20001
5 years, 1 month ago (2015-11-09 23:06:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423723006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423723006/40001
5 years, 1 month ago (2015-11-09 23:41:57 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-10 00:57:56 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 00:58:41 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b9eb2c66e29459a5ba5ade86181d40ec0fa3977f
Cr-Commit-Position: refs/heads/master@{#358723}

Powered by Google App Engine
This is Rietveld 408576698