Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java

Issue 1423723006: Hard-code tap resolve and prefetch limits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tap_promo
Patch Set: Add @VisibleForTesting annotation Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
index 210cf452ad47daa53c7c24286f5c850dd7fec96c..0e5c2d92d3ec2dc36a81abe2f886bf78d4efcfdc 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
@@ -25,11 +25,6 @@ public class ContextualSearchFieldTrial {
static final String PROMO_ON_LIMITED_TAPS = "promo_on_limited_taps";
static final String TAP_TRIGGERED_PROMO_LIMIT = "tap_triggered_promo_limit";
- static final String TAP_RESOLVE_LIMIT_FOR_DECIDED = "tap_resolve_limit_for_decided";
- static final String TAP_PREFETCH_LIMIT_FOR_DECIDED = "tap_prefetch_limit_for_decided";
- static final String TAP_RESOLVE_LIMIT_FOR_UNDECIDED = "tap_resolve_limit_for_undecided";
- static final String TAP_PREFETCH_LIMIT_FOR_UNDECIDED = "tap_prefetch_limit_for_undecided";
-
static final String PEEK_PROMO_FORCED = "peek_promo_forced";
static final String PEEK_PROMO_ENABLED = "peek_promo_enabled";
static final String PEEK_PROMO_MAX_SHOW_COUNT = "peek_promo_max_show_count";
@@ -43,10 +38,6 @@ public class ContextualSearchFieldTrial {
// Tap handling.
private static final int UNLIMITED_TAPS = -1;
- private static final int DEFAULT_TAP_RESOLVE_LIMIT_FOR_DECIDED = UNLIMITED_TAPS;
- private static final int DEFAULT_TAP_PREFETCH_LIMIT_FOR_DECIDED = UNLIMITED_TAPS;
- private static final int DEFAULT_TAP_RESOLVE_LIMIT_FOR_UNDECIDED = 100;
- private static final int DEFAULT_TAP_PREFETCH_LIMIT_FOR_UNDECIDED = 10;
// Cached values to avoid repeated and redundant JNI operations.
private static Boolean sEnabled;
@@ -121,71 +112,6 @@ public class ContextualSearchFieldTrial {
}
/**
- * @return Whether Search Term Resolution in response to a Tap gesture is limited for decided
- * users.
- */
- static boolean isTapResolveLimitedForDecided() {
- return getTapResolveLimitForDecided() != ContextualSearchFieldTrial.UNLIMITED_TAPS;
- }
-
- /**
- * @return Whether prefetch in response to a Tap gesture is limited for decided users.
- */
- static boolean isTapPrefetchLimitedForDecided() {
- return getTapPrefetchLimitForDecided() != ContextualSearchFieldTrial.UNLIMITED_TAPS;
- }
-
- /**
- * @return Whether Search Term Resolution in response to a Tap gesture is limited for undecided
- * users.
- */
- static boolean isTapResolveLimitedForUndecided() {
- return getTapResolveLimitForUndecided() != ContextualSearchFieldTrial.UNLIMITED_TAPS;
- }
-
- /**
- * @return Whether prefetch in response to a Tap gesture is limited for undecided users.
- */
- static boolean isTapPrefetchLimitedForUndecided() {
- return getTapPrefetchLimitForUndecided() != ContextualSearchFieldTrial.UNLIMITED_TAPS;
- }
- /**
- * @return The limit on the number of taps to resolve for decided users, or the default if no
- * value is present in the Finch configuration.
- */
- static int getTapResolveLimitForDecided() {
- return getIntParamValueOrDefault(TAP_RESOLVE_LIMIT_FOR_DECIDED,
- DEFAULT_TAP_RESOLVE_LIMIT_FOR_DECIDED);
- }
-
- /**
- * @return The limit on the number of prefetches to issue for decided users, or the default
- * if no value is present.
- */
- static int getTapPrefetchLimitForDecided() {
- return getIntParamValueOrDefault(TAP_PREFETCH_LIMIT_FOR_DECIDED,
- DEFAULT_TAP_PREFETCH_LIMIT_FOR_DECIDED);
- }
-
- /**
- * @return The limit on the number of taps to resolve for undecided users, or the default if no
- * value is present in the Finch configuration.
- */
- static int getTapResolveLimitForUndecided() {
- return getIntParamValueOrDefault(TAP_RESOLVE_LIMIT_FOR_UNDECIDED,
- DEFAULT_TAP_RESOLVE_LIMIT_FOR_UNDECIDED);
- }
-
- /**
- * @return The limit on the number of prefetches to issue for undecided users, or the default
- * if no value is present.
- */
- static int getTapPrefetchLimitForUndecided() {
- return getIntParamValueOrDefault(TAP_PREFETCH_LIMIT_FOR_UNDECIDED,
- DEFAULT_TAP_PREFETCH_LIMIT_FOR_UNDECIDED);
- }
-
- /**
* @return Whether the Peek Promo is forcibly enabled (used for testing).
*/
static boolean isPeekPromoForced() {
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698