Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: chrome/browser/prefs/chrome_pref_service_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged ToT Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/chrome_pref_service_unittest.cc
diff --git a/chrome/browser/prefs/chrome_pref_service_unittest.cc b/chrome/browser/prefs/chrome_pref_service_unittest.cc
index a3cb07d1899d46a6fd74fe44d73b3f444dba7f09..3f9a0369497fab9234a8aabb52a0b68cc024c498 100644
--- a/chrome/browser/prefs/chrome_pref_service_unittest.cc
+++ b/chrome/browser/prefs/chrome_pref_service_unittest.cc
@@ -23,12 +23,10 @@
#include "chrome/test/base/testing_pref_service_syncable.h"
#include "chrome/test/base/testing_profile.h"
#include "components/user_prefs/pref_registry_syncable.h"
-#include "content/public/test/test_browser_thread.h"
#include "content/public/test/web_contents_tester.h"
#include "ui/base/test/data/resource.h"
#include "webkit/common/webpreferences.h"
-using content::BrowserThread;
using content::WebContentsTester;
TEST(ChromePrefServiceTest, UpdateCommandLinePrefStore) {
@@ -144,10 +142,6 @@ TEST_F(ChromePrefServiceUserFilePrefsTest, PreserveEmptyValue) {
class ChromePrefServiceWebKitPrefs : public ChromeRenderViewHostTestHarness {
protected:
- ChromePrefServiceWebKitPrefs()
- : ui_thread_(BrowserThread::UI, &message_loop_) {
- }
-
virtual void SetUp() {
ChromeRenderViewHostTestHarness::SetUp();
@@ -172,9 +166,6 @@ class ChromePrefServiceWebKitPrefs : public ChromeRenderViewHostTestHarness {
pref_services->SetUserPref("webkit.webprefs.foo",
Value::CreateStringValue("bar"));
}
-
- private:
- content::TestBrowserThread ui_thread_;
};
// Tests to see that webkit preferences are properly loaded and copied over

Powered by Google App Engine
This is Rietveld 408576698