Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2344)

Unified Diff: chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged ToT Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc
diff --git a/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc b/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc
index 034cbdc3ec3d6c948f86ad880ff4f9c6b0821f5c..66fabfaed688ea22598c2e3a0af1653580515086 100644
--- a/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc
+++ b/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc
@@ -32,10 +32,9 @@
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
-using ::testing::Return;
-using ::testing::StrictMock;
-using content::BrowserThread;
using content::WebContentsTester;
+using testing::Return;
+using testing::StrictMock;
namespace safe_browsing {
namespace {
@@ -50,10 +49,6 @@ class MockClientSideDetectionService : public ClientSideDetectionService {
class BrowserFeatureExtractorTest : public ChromeRenderViewHostTestHarness {
protected:
- BrowserFeatureExtractorTest()
- : ui_thread_(BrowserThread::UI, &message_loop_) {
- }
-
virtual void SetUp() {
ChromeRenderViewHostTestHarness::SetUp();
profile()->CreateHistoryService(true /* delete_file */, false /* no_db */);
@@ -161,7 +156,6 @@ class BrowserFeatureExtractorTest : public ChromeRenderViewHostTestHarness {
}
}
- content::TestBrowserThread ui_thread_;
int num_pending_;
scoped_ptr<BrowserFeatureExtractor> extractor_;
std::map<ClientPhishingRequest*, bool> success_;

Powered by Google App Engine
This is Rietveld 408576698