Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: chrome/browser/password_manager/password_manager_unittest.cc

Issue 14197014: Add TestBrowserThreadBundle into RenderViewHostTestHarness. Kill some unnecessary real threads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merged ToT Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_unittest.cc
diff --git a/chrome/browser/password_manager/password_manager_unittest.cc b/chrome/browser/password_manager/password_manager_unittest.cc
index 8ce8e3957a556656b6d59db4131ed198535738ab..3dd46df8660f24bb07c737f4d62498ed94a97e92 100644
--- a/chrome/browser/password_manager/password_manager_unittest.cc
+++ b/chrome/browser/password_manager/password_manager_unittest.cc
@@ -23,13 +23,12 @@
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
-using content::BrowserThread;
using content::PasswordForm;
using testing::_;
using testing::DoAll;
-using ::testing::Exactly;
-using ::testing::WithArg;
-using ::testing::Return;
+using testing::Exactly;
+using testing::Return;
+using testing::WithArg;
class MockPasswordManagerDelegate : public PasswordManagerDelegate {
public:
@@ -48,11 +47,6 @@ ACTION_P(SaveToScopedPtr, scoped) {
}
class PasswordManagerTest : public ChromeRenderViewHostTestHarness {
- public:
- PasswordManagerTest()
- : ui_thread_(BrowserThread::UI, base::MessageLoopForUI::current()) {}
- virtual ~PasswordManagerTest() {}
-
protected:
virtual void SetUp() {
testing_profile_ = new TestingProfile;
@@ -93,9 +87,6 @@ class PasswordManagerTest : public ChromeRenderViewHostTestHarness {
return PasswordManager::FromWebContents(web_contents());
}
- // We create a UI thread to satisfy PasswordStore.
- content::TestBrowserThread ui_thread_;
-
scoped_refptr<MockPasswordStore> store_;
MockPasswordManagerDelegate delegate_; // Owned by manager_.

Powered by Google App Engine
This is Rietveld 408576698