Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1791)

Issue 14185003: Use ContextMenu code path that was guarded by CROSS_PLATFORM_CONTEXT_MENU (Closed)

Created:
7 years, 8 months ago by jeez
Modified:
7 years, 8 months ago
CC:
blink-reviews, caseq+blink_chromium.org, Nate Chapin, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, gavinp+loader_chromium.org, haraken, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use ContextMenu code path that was guarded by CROSS_PLATFORM_CONTEXT_MENU Here this flag is also removed and functions related to selecting an item now receive a const ContextMenuItem*, cleaning up a few const_cast. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148457

Patch Set 1 #

Patch Set 2 : Use ContextMenu code path that was guarded by CROSS_PLATFORM_CONTEXT_MENU #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -317 lines) Patch
M Source/WebCore/inspector/InspectorFrontendHost.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/loader/EmptyClients.h View 1 1 chunk +1 line, -5 lines 0 comments Download
M Source/WebCore/loader/EmptyClients.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/page/ContextMenuClient.h View 2 chunks +2 lines, -7 lines 0 comments Download
M Source/WebCore/page/ContextMenuController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/page/ContextMenuController.cpp View 3 chunks +1 line, -10 lines 0 comments Download
M Source/WebCore/page/ContextMenuProvider.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/ContextMenu.h View 3 chunks +6 lines, -30 lines 0 comments Download
M Source/WebCore/platform/ContextMenu.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M Source/WebCore/platform/ContextMenuItem.h View 5 chunks +4 lines, -40 lines 0 comments Download
M Source/WebCore/platform/ContextMenuItem.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
D Source/WebCore/platform/PlatformMenuDescription.h View 1 chunk +0 lines, -45 lines 0 comments Download
M Source/WebCore/platform/chromium/ContextMenuChromium.cpp View 1 chunk +10 lines, -58 lines 0 comments Download
M Source/WebCore/platform/chromium/ContextMenuItemChromium.cpp View 1 chunk +4 lines, -90 lines 0 comments Download
M Source/WebKit/chromium/src/ContextMenuClientImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/ContextMenuClientImpl.cpp View 7 chunks +10 lines, -11 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jeez
7 years, 8 months ago (2013-04-11 20:51:50 UTC) #1
abarth-chromium
lgtm
7 years, 8 months ago (2013-04-11 20:52:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/forgerbr@gmail.com/14185003/1
7 years, 8 months ago (2013-04-11 20:57:43 UTC) #3
Julien - ping for review
Jeez didn't sign the CLA so holding off on landing the change, but I agree ...
7 years, 8 months ago (2013-04-11 21:01:34 UTC) #4
abarth-chromium
Oh, sorry. We need an automated way to check that.
7 years, 8 months ago (2013-04-11 21:02:54 UTC) #5
Julien - ping for review
On 2013/04/11 21:02:54, abarth wrote: > Oh, sorry. We need an automated way to check ...
7 years, 8 months ago (2013-04-11 21:22:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/forgerbr@gmail.com/14185003/1
7 years, 8 months ago (2013-04-11 21:23:07 UTC) #7
eseidel
Enforcing the CLA w/o automation is impractical/impossible. https://code.google.com/p/chromium/issues/detail?id=230038
7 years, 8 months ago (2013-04-11 21:24:02 UTC) #8
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-11 21:31:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/forgerbr@gmail.com/14185003/1
7 years, 8 months ago (2013-04-12 00:41:47 UTC) #10
jeez
On 2013/04/12 00:41:47, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 8 months ago (2013-04-12 02:56:10 UTC) #11
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-12 03:45:02 UTC) #12
jochen (gone - plz use gerrit)
7 years, 8 months ago (2013-04-16 11:00:22 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 manually as r148457 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698