Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: Source/WebCore/platform/ContextMenu.cpp

Issue 14185003: Use ContextMenu code path that was guarded by CROSS_PLATFORM_CONTEXT_MENU (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use ContextMenu code path that was guarded by CROSS_PLATFORM_CONTEXT_MENU Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/WebCore/platform/ContextMenu.h ('k') | Source/WebCore/platform/ContextMenuItem.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
14 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, 14 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
15 * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
17 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 17 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
18 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF 18 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
19 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS 19 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
20 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN 20 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
21 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) 21 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
22 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 22 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
23 * THE POSSIBILITY OF SUCH DAMAGE. 23 * THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "config.h" 26 #include "config.h"
27 #include "ContextMenu.h" 27 #include "ContextMenu.h"
28 28
29 #if ENABLE(CONTEXT_MENUS) && USE(CROSS_PLATFORM_CONTEXT_MENUS) 29 #if ENABLE(CONTEXT_MENUS)
30 30
31 namespace WebCore { 31 namespace WebCore {
32 32
33 ContextMenu::ContextMenu() 33 ContextMenu::ContextMenu()
34 { 34 {
35 } 35 }
36 36
37 static const ContextMenuItem* findItemWithAction(unsigned action, const Vector<C ontextMenuItem>& items) 37 static const ContextMenuItem* findItemWithAction(unsigned action, const Vector<C ontextMenuItem>& items)
38 { 38 {
39 for (size_t i = 0; i < items.size(); ++i) { 39 for (size_t i = 0; i < items.size(); ++i) {
40 const ContextMenuItem& item = items[i]; 40 const ContextMenuItem& item = items[i];
41 if (item.action() == static_cast<ContextMenuAction>(action)) 41 if (item.action() == static_cast<ContextMenuAction>(action))
42 return &item; 42 return &item;
43 if (item.type() != SubmenuType) 43 if (item.type() != SubmenuType)
44 continue; 44 continue;
45 if (const ContextMenuItem* subMenuItem = findItemWithAction(action, item .subMenuItems())) 45 if (const ContextMenuItem* subMenuItem = findItemWithAction(action, item .subMenuItems()))
46 return subMenuItem; 46 return subMenuItem;
47 } 47 }
48 48
49 return 0; 49 return 0;
50 } 50 }
51 51
52 ContextMenuItem* ContextMenu::itemWithAction(unsigned action) 52 const ContextMenuItem* ContextMenu::itemWithAction(unsigned action)
53 { 53 {
54 // FIXME: When more platforms switch over, this fucntion should return a con st ContextMenuItem*'s, and the const_cast 54 return findItemWithAction(action, m_items);
55 // won't be needed anymore.
56 return const_cast<ContextMenuItem*>(findItemWithAction(action, m_items));
57 } 55 }
58 56
59 } // namespace WebCore 57 } // namespace WebCore
60 58
61 #endif // ENABLE(CONTEXT_MENUS) && USE(CROSS_PLATFORM_CONTEXT_MENUS) 59 #endif // ENABLE(CONTEXT_MENUS)
OLDNEW
« no previous file with comments | « Source/WebCore/platform/ContextMenu.h ('k') | Source/WebCore/platform/ContextMenuItem.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698