Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1414483008: Add CMP(register) and CMP(Immediate) to ARM integerated assembler. (Closed)

Created:
5 years, 1 month ago by Karl
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add CMP(register) and CMP(Immediate) to ARM integerated assembler. Also cleans up comments on rotated immediate 8 constants. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4334 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=f8fc12f741cdbffaf82005d4f1324dc316d9d6df

Patch Set 1 #

Patch Set 2 : Fix nits. #

Total comments: 6

Patch Set 3 : Fix nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -99 lines) Patch
M src/DartARM32/assembler_arm.h View 1 2 4 chunks +10 lines, -1 line 0 comments Download
M src/DartARM32/assembler_arm.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 1 2 10 chunks +68 lines, -8 lines 0 comments Download
M src/IceInstARM32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceInstARM32.cpp View 1 2 2 chunks +16 lines, -0 lines 0 comments Download
M tests_lit/assembler/arm32/branch-mult-fwd.ll View 1 2 2 chunks +98 lines, -90 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Karl
5 years, 1 month ago (2015-10-30 20:17:54 UTC) #3
Jim Stichnoth
lgtm https://codereview.chromium.org/1414483008/diff/20001/src/IceAssemblerARM32.cpp File src/IceAssemblerARM32.cpp (right): https://codereview.chromium.org/1414483008/diff/20001/src/IceAssemblerARM32.cpp#newcode172 src/IceAssemblerARM32.cpp:172: assert((RotateAmt < (1 << kRotateBits)) && (Immed8 < ...
5 years, 1 month ago (2015-10-30 21:41:11 UTC) #4
Karl
Committed patchset #3 (id:40001) manually as f8fc12f741cdbffaf82005d4f1324dc316d9d6df (presubmit successful).
5 years, 1 month ago (2015-10-30 22:06:40 UTC) #5
Karl
5 years, 1 month ago (2015-10-30 22:06:56 UTC) #6
Message was sent while issue was closed. 
https://chromiumcodereview.appspot.com/1414483008/diff/20001/src/IceAssembler...
File src/IceAssemblerARM32.cpp (right):

https://chromiumcodereview.appspot.com/1414483008/diff/20001/src/IceAssembler...
src/IceAssemblerARM32.cpp:172: assert((RotateAmt < (1 << kRotateBits)) &&
(Immed8 < (1 << kImmed8Bits)));
On 2015/10/30 21:41:11, stichnot wrote:
> Something like:
>   assert(a && b);
> is better done as:
>   assert(a);
>   assert(b);
> so you get more specific details on the assertion failure.

Done.

https://chromiumcodereview.appspot.com/1414483008/diff/20001/src/IceAssembler...
src/IceAssemblerARM32.cpp:586: // Intenionally fall to next case!
On 2015/10/30 21:41:11, stichnot wrote:
> Intentionally

Done.

https://chromiumcodereview.appspot.com/1414483008/diff/20001/tests_lit/assemb...
File tests_lit/assembler/arm32/branch-mult-fwd.ll (right):

https://chromiumcodereview.appspot.com/1414483008/diff/20001/tests_lit/assemb...
tests_lit/assembler/arm32/branch-mult-fwd.ll:81: ; IASM-NEXT:	.byte 0x2
On 2015/10/30 21:41:11, stichnot wrote:
> Probably better if you untabify this file.

Done.

Powered by Google App Engine
This is Rietveld 408576698