Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1414453016: Data use UI fixes (Closed)

Created:
5 years, 1 month ago by megjablon
Modified:
5 years, 1 month ago
Reviewers:
newt (away)
CC:
chromium-reviews, bengr
Base URL:
https://chromium.googlesource.com/chromium/src.git@plateIntentSource
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Data use UI fixes Adds 'Learn more' and 'More' links to the data use dialog and snackbar, respectively. Fixes text color and size in the dialog. BUG=551192 Committed: https://crrev.com/2641bbb33465cf9d2442886162e4911cd91c011c Cr-Commit-Position: refs/heads/master@{#358853}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Adding title #

Patch Set 3 : Add EmbedContentViewActivity for snackbar more action #

Patch Set 4 : ending snackbar has separate message #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -17 lines) Patch
M chrome/android/java/res/layout/data_use_dialog.xml View 1 chunk +30 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java View 2 chunks +12 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java View 1 2 3 3 chunks +8 lines, -3 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 3 4 1 chunk +13 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
megjablon
PTAL, thanks! See bug for mock.
5 years, 1 month ago (2015-11-09 22:53:49 UTC) #3
newt (away)
lgtm after comment https://chromiumcodereview.appspot.com/1414453016/diff/20001/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://chromiumcodereview.appspot.com/1414453016/diff/20001/chrome/android/java/strings/android_chrome_strings.grd#newcode799 chrome/android/java/strings/android_chrome_strings.grd:799: <!-- Intentionally empty. This is overridden ...
5 years, 1 month ago (2015-11-09 23:13:42 UTC) #4
megjablon
https://chromiumcodereview.appspot.com/1414453016/diff/20001/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://chromiumcodereview.appspot.com/1414453016/diff/20001/chrome/android/java/strings/android_chrome_strings.grd#newcode799 chrome/android/java/strings/android_chrome_strings.grd:799: <!-- Intentionally empty. This is overridden downstream. --> On ...
5 years, 1 month ago (2015-11-09 23:18:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1414453016/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1414453016/100001
5 years, 1 month ago (2015-11-10 18:02:56 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 1 month ago (2015-11-10 18:23:11 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 18:24:11 UTC) #10
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/2641bbb33465cf9d2442886162e4911cd91c011c
Cr-Commit-Position: refs/heads/master@{#358853}

Powered by Google App Engine
This is Rietveld 408576698