Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4277)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java

Issue 1414453016: Data use UI fixes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@plateIntentSource
Patch Set: rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java
index adacddf0b3761b3ea7672ce887ddc40f3bf5d538..eb295d86dea5563cf88bb3bba484d897e9e102ae 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java
@@ -7,6 +7,7 @@ package org.chromium.chrome.browser.snackbar;
import android.content.Context;
import org.chromium.chrome.R;
+import org.chromium.chrome.browser.EmbedContentViewActivity;
/**
* The controller for two data use snackbars:
@@ -34,14 +35,16 @@ public class DataUseSnackbarController implements SnackbarManager.SnackbarContro
public void showDataUseTrackingStartedBar() {
mSnackbarManager.showSnackbar(Snackbar.make(
mContext.getString(R.string.data_use_tracking_started_snackbar_message), this)
- .setAction(mContext.getString(R.string.data_use_tracking_started_snackbar_action),
+ .setAction(mContext.getString(R.string.data_use_tracking_snackbar_action),
null));
// TODO(megjablon): Add metrics.
}
public void showDataUseTrackingEndedBar() {
mSnackbarManager.showSnackbar(Snackbar.make(
- mContext.getString(R.string.data_use_tracking_ended_title), this));
+ mContext.getString(R.string.data_use_tracking_ended_snackbar_message), this)
+ .setAction(mContext.getString(R.string.data_use_tracking_snackbar_action),
+ null));
// TODO(megjablon): Add metrics.
}
@@ -57,7 +60,9 @@ public class DataUseSnackbarController implements SnackbarManager.SnackbarContro
*/
@Override
public void onAction(Object actionData) {
- // TODO(megjablon): Load the more page and add metrics.
+ // TODO(megjablon): Add metrics.
+ EmbedContentViewActivity.show(mContext, R.string.data_use_learn_more_title,
+ R.string.data_use_learn_more_link_url);
}
@Override

Powered by Google App Engine
This is Rietveld 408576698