Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4075)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java

Issue 1414453016: Data use UI fixes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@plateIntentSource
Patch Set: rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java b/chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java
index 035a9922aee6660f14be298c319757a4203c1b77..bfe84272bbb0b15aa2efd25bf394c7741d41cf86 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java
@@ -15,6 +15,7 @@ import android.view.View;
import android.widget.CheckBox;
import org.chromium.chrome.R;
+import org.chromium.chrome.browser.EmbedContentViewActivity;
import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.sessions.SessionTabHelper;
import org.chromium.chrome.browser.tab.Tab;
@@ -100,12 +101,19 @@ public class DataUseTabUIManager {
*/
private static void startDataUseDialog(final Activity activity, final Tab tab,
final String url, final int pageTransitionType, final String referrerUrl) {
- View checkBoxView = View.inflate(activity, R.layout.data_use_dialog, null);
- final CheckBox checkBox = (CheckBox) checkBoxView.findViewById(R.id.data_use_checkbox);
+ View dataUseDialogView = View.inflate(activity, R.layout.data_use_dialog, null);
+ final CheckBox checkBox = (CheckBox) dataUseDialogView.findViewById(R.id.data_use_checkbox);
+ View learnMore = dataUseDialogView.findViewById(R.id.learn_more);
+ learnMore.setOnClickListener(new android.view.View.OnClickListener() {
+ @Override
+ public void onClick(View v) {
+ EmbedContentViewActivity.show(activity, R.string.data_use_learn_more_title,
+ R.string.data_use_learn_more_link_url);
+ }
+ });
new AlertDialog.Builder(activity, R.style.AlertDialogTheme)
.setTitle(R.string.data_use_tracking_ended_title)
- .setMessage(R.string.data_use_tracking_ended_message)
- .setView(checkBoxView)
+ .setView(dataUseDialogView)
.setPositiveButton(R.string.data_use_tracking_ended_continue,
new OnClickListener() {
@Override

Powered by Google App Engine
This is Rietveld 408576698