Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1412423004: Web Animations: Move property handle filtering into AnimationStack building (Closed)

Created:
5 years, 2 months ago by alancutter (OOO until 2018)
Modified:
5 years, 1 month ago
Reviewers:
dstockwell, Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, krit, Eric Willigers, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_svgAdditiveApplication
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web Animations: Move property handle filtering into AnimationStack building Previously we were filtering out PropertyHandle types while iterating over an AnimationStack. This change pushes the filter into the construction of the AnimationStack to avoid having undesirable entries in the first place. Committed: https://crrev.com/2fb3f8fa8fda5c1322aa26d760e04b4397850f9a Cr-Commit-Position: refs/heads/master@{#357045}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Patch Set 3 : endl #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -20 lines) Patch
M third_party/WebKit/Source/core/animation/AnimationStack.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationStack.cpp View 1 4 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 1 2 4 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp View 1 2 3 2 chunks +6 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (5 generated)
alancutter (OOO until 2018)
5 years, 2 months ago (2015-10-21 00:16:06 UTC) #2
dstockwell
https://codereview.chromium.org/1412423004/diff/1/third_party/WebKit/Source/core/animation/AnimationStack.cpp File third_party/WebKit/Source/core/animation/AnimationStack.cpp (right): https://codereview.chromium.org/1412423004/diff/1/third_party/WebKit/Source/core/animation/AnimationStack.cpp#newcode98 third_party/WebKit/Source/core/animation/AnimationStack.cpp:98: // We don't exactly know when new animations will ...
5 years, 2 months ago (2015-10-21 01:00:39 UTC) #3
alancutter (OOO until 2018)
https://codereview.chromium.org/1412423004/diff/1/third_party/WebKit/Source/core/animation/AnimationStack.cpp File third_party/WebKit/Source/core/animation/AnimationStack.cpp (right): https://codereview.chromium.org/1412423004/diff/1/third_party/WebKit/Source/core/animation/AnimationStack.cpp#newcode98 third_party/WebKit/Source/core/animation/AnimationStack.cpp:98: // We don't exactly know when new animations will ...
5 years, 2 months ago (2015-10-21 04:22:16 UTC) #4
dstockwell
lgtm
5 years, 1 month ago (2015-10-27 06:56:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412423004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412423004/40001
5 years, 1 month ago (2015-10-30 03:13:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/88025) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-10-30 03:15:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412423004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412423004/60001
5 years, 1 month ago (2015-10-30 03:20:08 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-10-30 04:32:26 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 04:33:28 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2fb3f8fa8fda5c1322aa26d760e04b4397850f9a
Cr-Commit-Position: refs/heads/master@{#357045}

Powered by Google App Engine
This is Rietveld 408576698