Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1410943004: Make SVG attribute interpolation test helper use testharness (Closed)

Created:
5 years, 1 month ago by alancutter (OOO until 2018)
Modified:
5 years, 1 month ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_cleanUpSVGInterpolationTestHelper
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SVG attribute interpolation test helper use testharness This patch changes the SVG interpolation test helper to use testharness and remove the need to include -expected.txt files. BUG=530436 Committed: https://crrev.com/c67ec714498bef41566492caaf4c18c1a93f6c07 Cr-Commit-Position: refs/heads/master@{#357304}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+490 lines, -2502 lines) Patch
M third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/resources/interpolation-test.js View 1 9 chunks +150 lines, -284 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-amplitude-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-azimuth-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-baseFrequency-interpolation-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-bias-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-class-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-clipPathUnits-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-cx-interpolation-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-d-interpolation-expected.txt View 1 chunk +303 lines, -304 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-diffuseConstant-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-divisor-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-dx-interpolation-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-edgeMode-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-elevation-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-exponent-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-filterUnits-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-fx-interpolation-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-gradientTransform-interpolation-expected.txt View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-gradientUnits-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-height-interpolation-expected.txt View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-href-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-in-interpolation-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-intercept-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-k1-interpolation-expected.txt View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-kernelMatrix-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-kernelUnitLength-interpolation-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-lengthAdjust-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-limitingConeAngle-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-markerHeight-interpolation-expected.txt View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-markerUnits-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-markerWidth-interpolation-expected.txt View 1 chunk +0 lines, -57 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-maskContentUnits-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-maskUnits-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-method-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-mode-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-numOctaves-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-offset-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-operator-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-order-interpolation-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-orient-interpolation-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-pathLength-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-patternContentUnits-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-patternTransform-interpolation-expected.txt View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-patternUnits-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-points-interpolation-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-pointsAtX-interpolation-expected.txt View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-preserveAlpha-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-preserveAspectRatio-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-primitiveUnits-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-r-interpolation-expected.txt View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-radius-interpolation-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-refX-interpolation-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-result-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-rotate-interpolation-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-rx-interpolation-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-scale-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-seed-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-slope-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-spacing-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-specularConstant-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-specularExponent-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-spreadMethod-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-startOffset-interpolation-expected.txt View 1 chunk +37 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-stdDeviation-interpolation-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-stitchTiles-interpolation-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-surfaceScale-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-tableValues-interpolation-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-target-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-targetX-interpolation-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-textLength-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-transform-interpolation-expected.txt View 1 chunk +0 lines, -106 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-type-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-values-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-viewBox-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-width-interpolation-expected.txt View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-x-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-x1-interpolation-expected.txt View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-xChannelSelector-interpolation-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-y-interpolation-expected.txt View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/svg-attribute-interpolation/svg-z-interpolation-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download

Depends on Patchset:

Issue 1412423004 Patch 60001

Dependent Patchsets:

Issue 1411043006 Patch 1
Issue 1420483003 Patch 20001
Issue 1411043006 Patch 20001

Messages

Total messages: 11 (4 generated)
alancutter (OOO until 2018)
5 years, 1 month ago (2015-10-30 08:35:26 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410943004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410943004/20001
5 years, 1 month ago (2015-10-30 10:10:55 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-30 11:13:10 UTC) #6
dstockwell
lgtm
5 years, 1 month ago (2015-11-02 03:14:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410943004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410943004/20001
5 years, 1 month ago (2015-11-02 03:22:52 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-02 04:24:47 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 04:25:46 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c67ec714498bef41566492caaf4c18c1a93f6c07
Cr-Commit-Position: refs/heads/master@{#357304}

Powered by Google App Engine
This is Rietveld 408576698