Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 141073009: Add forgive_all to enable experimental builders. (Closed)

Created:
6 years, 11 months ago by ghost stip (do not use)
Modified:
6 years, 11 months ago
Reviewers:
cmp, hinoka
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org, iannucci
Visibility:
Public.

Description

Add forgive_all to enable experimental builders. This enables us to notify specific watchers of waterfalls without radically altering gatekeeper.json. This patch enables that for both master.chromium and master.lkgr. It enables this on both master.chromium and master.chromium.lkgr, and removes sheriffing on master.chromium. This paves the way to remove the chromium-build whitelist, unblocking 304763. It also adds wfh and scottmg to gatekeeper.json. BUG=304763, 335234 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=245711

Patch Set 1 #

Patch Set 2 : Correct typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -9 lines) Patch
M scripts/slave/gatekeeper.json View 2 chunks +6 lines, -4 lines 0 comments Download
M scripts/slave/gatekeeper_ng.py View 3 chunks +18 lines, -5 lines 0 comments Download
M scripts/slave/unittests/gatekeeper_ng_test.py View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ghost stip (do not use)
ptal
6 years, 11 months ago (2014-01-18 00:25:24 UTC) #1
ghost stip (do not use)
load-balancing against iannucci :) lmk if you need me to walk you through this
6 years, 11 months ago (2014-01-18 00:27:24 UTC) #2
cmp
lgtm
6 years, 11 months ago (2014-01-18 01:50:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stip@chromium.org/141073009/40001
6 years, 11 months ago (2014-01-18 01:52:54 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-18 01:53:59 UTC) #5
Message was sent while issue was closed.
Change committed as 245711

Powered by Google App Engine
This is Rietveld 408576698