Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: scripts/slave/unittests/gatekeeper_ng_test.py

Issue 141073009: Add forgive_all to enable experimental builders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Correct typo. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/gatekeeper_ng.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/unittests/gatekeeper_ng_test.py
diff --git a/scripts/slave/unittests/gatekeeper_ng_test.py b/scripts/slave/unittests/gatekeeper_ng_test.py
index 689bd4e388cc3c03e2c752d65e04952cf970ef0b..8ce750f735993914ff449a0d876637e2dbbfff4c 100755
--- a/scripts/slave/unittests/gatekeeper_ng_test.py
+++ b/scripts/slave/unittests/gatekeeper_ng_test.py
@@ -860,6 +860,24 @@ class GatekeeperTest(unittest.TestCase):
self.assertNotIn(self.mailer_url, urls)
self.assertIn(self.status_url, urls)
+ def testForgiveAllSteps(self):
+ """Test that setting forgive_all prevents emailing the blamelist."""
+ sys.argv.extend([m.url for m in self.masters])
+ sys.argv.extend(['--skip-build-db-update',
+ '--json', self.gatekeeper_file,
+ '--email-app-secret-file=%s' % self.email_secret_file,
+ '--set-status', '--password-file', self.status_secret_file
+ ])
+
+ self.masters[0].builders[0].builds[0].steps[1].results = [2, None]
+ self.add_gatekeeper_section(self.masters[0].url,
+ self.masters[0].builders[0].name,
+ {'closing_steps': ['step1'],
+ 'forgive_all': 'true'})
+ urls = self.call_gatekeeper()
+
+ self.assertNotIn(self.mailer_url, urls)
+ self.assertIn(self.status_url, urls)
#### Multiple failures.
« no previous file with comments | « scripts/slave/gatekeeper_ng.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698