Issue 14067007: Remove 3D_RENDERING define from Blink

Issue 14067007: Remove 3D_RENDERING define from Blink (Closed)

Created:
7 years, 8 months ago by shawnsingh

Modified:
7 years, 8 months ago

Reviewers:
Dirk Pranke, Julien - ping for review

CC:
blink-reviews, jamesr, Alexis Menard, abarth-chromium, apavlov+blink_chromium.org, jchaffraix+rendering, Stephen Chennney

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove 3D_RENDERING define from Blink This patch removes the 3D_RENDERING define, keeping the code as if 3D_RENDERING is enabled. It also removes a boolean variable that was being used by layout test infrastructure (only was being used by non-chromium WebKit ports) peering into the code via "nm" to determine if 3D_RENDERING was enabled. BUG=230224 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148241

Patch Set 1 #

Patch Set 2 : Rebased, retrying the bots #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -38 lines)			Patch
M	Source/WTF/wtf/FeatureDefines.h	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/WebCore/css/CSSComputedStyleDeclaration.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/WebCore/css/MediaQueryEvaluator.cpp	View		3 chunks	+1 line, -10 lines	0 comments	Download
M	Source/WebCore/platform/graphics/GraphicsContext.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/rendering/RenderLayerCompositor.cpp	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/WebCore/rendering/RenderObject.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/WebCore/rendering/RenderObject.cpp	View		3 chunks	+0 lines, -9 lines	0 comments	Download
M	Source/WebKit/chromium/features.gypi	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/base.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

shawnsingh

PTAL: jchaffraix@ for WebCore/ and WTF/ dpranke@ for Tools/Scripts/

7 years, 8 months ago (2013-04-11 03:59:30 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shawnsingh@chromium.org/14067007/6001

7 years, 8 months ago (2013-04-12 00:22:21 UTC) #4

Message was sent while issue was closed.

Change committed as 148241

Expand Messages | Collapse Messages