Remove certain context menu items for images.

Remove certain context menu items for images.

Removes:
  Open image in new tab
  Copy image
  Copy image URL

Hides:
  Copy link text for images

BUG=483685
Committed: https://crrev.com/a9daf22e6c22c653ae88e3255894a3b253ccd2cd
Cr-Commit-Position: refs/heads/master@{#354302}

[aurimas (slooooooooow), 2015-10-14 20:47:32]

The CQ bit was checked by aurimas@chromium.org to run a CQ dry run

[aurimas (slooooooooow), 2015-10-14 20:47:45]

aurimas@chromium.org changed reviewers:
+ newt@chromium.org

[aurimas (slooooooooow), 2015-10-14 20:47:45]

PTAL

[commit-bot: I haz the power, 2015-10-14 20:48:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1404793006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1404793006/60001

[commit-bot: I haz the power, 2015-10-14 22:34:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-14 22:34:22]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[aurimas (slooooooooow), 2015-10-14 23:10:29]

The CQ bit was checked by aurimas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-14 23:11:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1404793006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1404793006/80001

[commit-bot: I haz the power, 2015-10-14 23:48:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-14 23:48:15]

Dry run: This issue passed the CQ dry run.

[newt (away), 2015-10-15 02:50:48]

https://chromiumcodereview.appspot.com/1404793006/diff/80001/chrome/android/j...
File chrome/android/java/res/menu/chrome_context_menu.xml (left):

https://chromiumcodereview.appspot.com/1404793006/diff/80001/chrome/android/j...
chrome/android/java/res/menu/chrome_context_menu.xml:37: <item
android:id="@+id/contextmenu_copy_image_url"
Do we want to get rid of copy image URL before we have a replacement ("share")
in place?

https://chromiumcodereview.appspot.com/1404793006/diff/80001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java
(right):

https://chromiumcodereview.appspot.com/1404793006/diff/80001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java:228:
return new ChromeContextMenuPopulator(new TabContextMenuItemDelegate(this,
mActivity)) {
Food for thought: instead of duplicating logic here about which context menu
items to show, could we extend the normal ContextMenuPopulator, call
super.buildContextMenu(), and then hide the items that should never be visible
in custom tabs (e.g. open in new tab, open in new incognito tab, anything else?)

This would fix current and future bugs where the context menus are out of sync.
E.g. it's possible that we should be showing "loading original image" in custom
tabs mode, but we aren't currently.

(I'm suggesting this as a potential future change; not part of this CL)

https://chromiumcodereview.appspot.com/1404793006/diff/80001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java:241:
if (!TextUtils.isEmpty(linkText)) {
" && !params.isImage()"

https://chromiumcodereview.appspot.com/1404793006/diff/80001/chrome/android/j...
File
chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java
(right):

https://chromiumcodereview.appspot.com/1404793006/diff/80001/chrome/android/j...
chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java:261:
// Verify that the background tabs were opened in the expected order.
We should still test that background tabs are opened in the right order. You
could modify the test to open two links in the background instead of a link and
an image.

[aurimas (slooooooooow), 2015-10-15 16:25:35]

https://chromiumcodereview.appspot.com/1404793006/diff/80001/chrome/android/j...
File chrome/android/java/res/menu/chrome_context_menu.xml (left):

https://chromiumcodereview.appspot.com/1404793006/diff/80001/chrome/android/j...
chrome/android/java/res/menu/chrome_context_menu.xml:37: <item
android:id="@+id/contextmenu_copy_image_url"
On 2015/10/15 at 02:50:48, newt wrote:
> Do we want to get rid of copy image URL before we have a replacement ("share")
in place?

You can still access it by tapping "open image".

https://chromiumcodereview.appspot.com/1404793006/diff/80001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java
(right):

https://chromiumcodereview.appspot.com/1404793006/diff/80001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java:241:
if (!TextUtils.isEmpty(linkText)) {
On 2015/10/15 at 02:50:48, newt wrote:
> " && !params.isImage()"

Done

https://chromiumcodereview.appspot.com/1404793006/diff/80001/chrome/android/j...
File
chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java
(right):

https://chromiumcodereview.appspot.com/1404793006/diff/80001/chrome/android/j...
chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java:261:
// Verify that the background tabs were opened in the expected order.
On 2015/10/15 at 02:50:48, newt wrote:
> We should still test that background tabs are opened in the right order. You
could modify the test to open two links in the background instead of a link and
an image.

Done

[aurimas (slooooooooow), 2015-10-15 16:25:40]

The CQ bit was checked by aurimas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-15 16:25:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1404793006/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1404793006/100001

[commit-bot: I haz the power, 2015-10-15 17:33:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-15 17:33:54]

Dry run: This issue passed the CQ dry run.

[newt (away), 2015-10-15 17:56:34]

lgtm

[aurimas (slooooooooow), 2015-10-15 17:57:25]

The CQ bit was checked by aurimas@chromium.org

[commit-bot: I haz the power, 2015-10-15 17:57:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1404793006/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1404793006/100001

[commit-bot: I haz the power, 2015-10-15 18:04:19]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-10-15 18:05:13]

Patchset 6 (id:??) landed as
https://crrev.com/a9daf22e6c22c653ae88e3255894a3b253ccd2cd
Cr-Commit-Position: refs/heads/master@{#354302}