chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java - Issue 1404793006: Remove certain context menu items for images.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java

Issue 1404793006: Remove certain context menu items for images. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: newt's nits Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuItemDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java

index 4664ad7463e7be9b3501c36bb42053e2fa7814d2..70a4fb775918ad485d55f03231ecc2a13fb9f7cc 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java

@@ -238,7 +238,7 @@ public class CustomTab extends Tab {

String linkText = params.getLinkText();

if (linkText != null) linkText = linkText.trim();

- if (!TextUtils.isEmpty(linkText)) {

+ if (!TextUtils.isEmpty(linkText) && !params.isImage()) {

menu.add(Menu.NONE, org.chromium.chrome.R.id.contextmenu_copy_link_text,

Menu.NONE, org.chromium.chrome.R.string.contextmenu_copy_link_text);

}

@@ -247,10 +247,6 @@ public class CustomTab extends Tab {

R.string.contextmenu_save_image);

menu.add(Menu.NONE, R.id.contextmenu_open_image, Menu.NONE,

R.string.contextmenu_open_image);

- menu.add(Menu.NONE, R.id.contextmenu_copy_image, Menu.NONE,

- R.string.contextmenu_copy_image);

- menu.add(Menu.NONE, R.id.contextmenu_copy_image_url, Menu.NONE,

- R.string.contextmenu_copy_image_url);

} else if (UrlUtilities.isDownloadableScheme(params.getLinkUrl())) {

// "Save link" is not shown for image.

menu.add(Menu.NONE, R.id.contextmenu_save_link_as, Menu.NONE,