Issue 14029006: Properly handle user cancellation of signin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14029006: Properly handle user cancellation of signin. (Closed)

Created:
7 years, 8 months ago by Andrew T Wilson (Slow)

Modified:
7 years, 8 months ago

Reviewers:
Reid Kleckner, Roger Tawa OOO till Jul 10th

CC:
chromium-reviews, Raghu Simha, haitaol1, akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Properly handle user cancellation of signin. Send out NOTIFICATION_GOOGLE_SIGNIN_FAILED(REQUEST_CANCELED) if the user cancels an in-progress signin, or if the user chooses to create a new profile as part of signin (to cancel signin on the initial profile). BUG=180987 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193926

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -64 lines)			Patch
M	chrome/browser/signin/signin_manager.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/signin/signin_manager.cc	View	4 chunks	+33 lines, -19 lines	0 comments	Download
M	chrome/browser/signin/signin_manager_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper.cc	View	2 chunks	+12 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper_unittest.cc	View	3 chunks	+51 lines, -23 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler.cc	View	2 chunks	+23 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/atwilson@chromium.org/14029006/1

7 years, 8 months ago (2013-04-12 08:44:44 UTC) #3

Reid Kleckner

7 years, 8 months ago (2013-04-12 16:37:12 UTC) #5

Message was sent while issue was closed.

Bunch of leaks on the heapcheck bot:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Heapcheck/bu...

Expand Messages | Collapse Messages