Properly handle user cancellation of signin.

chrome/browser/ui/sync/one_click_signin_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/sync/one_click_signin_helper.h"
 
 #include <algorithm>
 #include <functional>
 #include <utility>
 #include <vector>
@@ skipping 1315 matching lines @@
 
   // Clear the redirect URL.
   redirect_url_ = GURL();
   sync_service->RemoveObserver(this);
 }
 
 void OneClickSigninHelper::SigninFailed(const GoogleServiceAuthError& error) {
   if (error_message_.empty() && !error.error_message().empty())
       error_message_ = error.error_message();
 
+  bool display_bubble = true;
   if (error_message_.empty()) {
     switch (error.state()) {
       case GoogleServiceAuthError::NONE:
         error_message_.clear();
         break;
       case GoogleServiceAuthError::SERVICE_UNAVAILABLE:
         error_message_ = l10n_util::GetStringUTF8(IDS_SYNC_UNRECOVERABLE_ERROR);
         break;
+      case GoogleServiceAuthError::REQUEST_CANCELED:
+        // If the user cancelled signin, then no need to display any error
+        // messages or anything - just go back to the NTP.
+        error_message_.clear();
+        display_bubble = false;
+        break;
       default:
         error_message_ = l10n_util::GetStringUTF8(IDS_SYNC_ERROR_SIGNING_IN);
         break;
     }
   }
-  RedirectOnSigninComplete();
+  RedirectOnSigninComplete(display_bubble);
 }
 
 void OneClickSigninHelper::SigninSuccess() {
-  RedirectOnSigninComplete();
+  RedirectOnSigninComplete(true);
 }
 
-void OneClickSigninHelper::RedirectOnSigninComplete() {
-  // Show the result in the sign-in bubble.
-  RedirectToNtpOrAppsPage(true);
+void OneClickSigninHelper::RedirectOnSigninComplete(bool show_bubble) {
+  // Show the result in the sign-in bubble if desired.
+  RedirectToNtpOrAppsPage(show_bubble);
   signin_tracker_.reset();
 }