Properly handle user cancellation of signin.

chrome/browser/signin/signin_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/signin/signin_manager.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/compiler_specific.h"
 #include "base/prefs/pref_service.h"
@@ skipping 582 matching lines @@
   EXPECT_EQ(0U, google_login_success_.size());
   EXPECT_EQ(3U, google_login_failure_.size());
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
 }
 
 TEST_F(SigninManagerTest, SignOutMidConnect) {
   manager_->Initialize(profile_.get());
   manager_->StartSignIn("username", "password", std::string(), std::string());
   manager_->SignOut();
   EXPECT_EQ(0U, google_login_success_.size());
-  EXPECT_EQ(0U, google_login_failure_.size());
+  EXPECT_EQ(1U, google_login_failure_.size());
 
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
 }
 
 TEST_F(SigninManagerTest, SignInWithOAuth) {
   manager_->Initialize(profile_.get());
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
 
   manager_->StartSignInWithOAuth("user@gmail.com", "password");
   EXPECT_TRUE(manager_->GetAuthenticatedUsername().empty());
@@ skipping 63 matching lines @@
       GURL("http://accounts.google.com/ServiceLogin?service=chromiumsync")));
   // http, not https, should not be treated as web based signin.
   EXPECT_FALSE(SigninManager::IsWebBasedSigninFlowURL(
       GURL("http://accounts.google.com/ServiceLogin?service=googlemail")));
   // chromiumsync is double-embedded in a continue query param.
   EXPECT_TRUE(SigninManager::IsWebBasedSigninFlowURL(
       GURL("https://accounts.google.com/CheckCookie?"
            "continue=https%3A%2F%2Fwww.google.com%2Fintl%2Fen-US%2Fchrome"
            "%2Fblank.html%3Fsource%3D3%26nonadv%3D1&service=chromiumsync")));
 }