Mac: Display a native bubble (instead of the JS one) after the web signin flow. (branched from http…

Mac: Display a native bubble (instead of the JS one) after the web signin flow. 

XIB changes: Deleted "Undo" button from the Bubble dialog, and copied the InformativePlaceholderText from  chrome/app/nibs/OneClickSigninDialog.xib, which allows the "Learn More" link to be displayed.

Part of a 3 CL Voltron, along with: 
[Win] https://codereview.chromium.org/13979003/ 
[GTK] https://codereview.chromium.org/14258007/

(branched off https://codereview.chromium.org/13979003/)

BUG=119728
TEST=Open Chrome. Delete all your profiles, so that you have a fresh one. Open a new tab, and press the "sign in" link in the top right corner. Sign in. Upon completion, this should show a native popup bubble, anchored off the wrench menu. If you try to log in with the same email in another profile, the bubble should display a sad error message. Check out the issue description for screenshots.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197769

[Alexei Svitkine (slow), 2013-04-19 19:21:26]

Haven't looked at the code yet, but first:

Please add a TEST= line specifying how to test your changes.

Please list your XIB changes in the CL description.

[noms, 2013-04-19 19:26:33]

Done! Sorry!

On 2013/04/19 19:21:26, Alexei Svitkine wrote:
> Haven't looked at the code yet, but first:
> 
> Please add a TEST= line specifying how to test your changes.
> 
> Please list your XIB changes in the CL description.

[Alexei Svitkine (slow), 2013-04-19 19:54:15]

Here's some initial comments.

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
File chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h (right):

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h:36:
errorMessage:(const string16&)errorMessage
Please document the parameters, particularly |errorMessage|.

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
File chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm (right):

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm:32:
isSyncDialog:false
false -> NO

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm:60: 
Nit: Remove extra blank line. One blank line here is ok.

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
File chrome/browser/ui/cocoa/one_click_signin_view_controller.h (right):

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_view_controller.h:41: -
(id)initWithNibName:(NSString*)nibName
Please document these params.

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_view_controller.h:45:
isSyncDialog:(bool)isSyncDialog
Use the Obj-C type BOOL (with values YES/NO) rather than the C++ type bool.

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
File chrome/browser/ui/cocoa/one_click_signin_view_controller.mm (right):

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_view_controller.mm:52: errorMessage_ =
base::SysUTF16ToNSString(errorMessage);
Make the ctor param type NSString* and pass in nil instead of std::string() when
you want to not have it, then you can change the [errorMessage_ length] != 0
check to just errorMessage_.

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_view_controller.mm:61: if
(isSyncDialog_ && !startSyncCallback_.is_null()) {
If |isSyncDialog_| is YES, then you're already DCHECK'ing that the callback
isn't NULL, so you don't need the second condition in the if.

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_view_controller.mm:148: // the
non-modal bubble already has a text content
Comments should be full sentences.

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_view_controller.mm:151: messageText =
l10n_util::GetNSStringWithFixup(IDS_ONE_CLICK_SIGNIN_DIALOG_MESSAGE);
Wrap this so it doesn't excede 80 chars.

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_view_controller.mm:158:
ui::ResourceBundle::SmallFont).GetNativeFont();
I suggest just having a fontSize local variable that's assigned differently
based on the if - that way you don't have to repeat the wordy ResourceBundle
call (which should also be good for binary size).

[noms (inactive), 2013-04-22 15:28:07]

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
File chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h (right):

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h:36:
errorMessage:(const string16&)errorMessage
On 2013/04/19 19:54:15, Alexei Svitkine wrote:
> Please document the parameters, particularly |errorMessage|.

Done.

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
File chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm (right):

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm:32:
isSyncDialog:false
On 2013/04/19 19:54:15, Alexei Svitkine wrote:
> false -> NO

Done.

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm:60: 
On 2013/04/19 19:54:15, Alexei Svitkine wrote:
> Nit: Remove extra blank line. One blank line here is ok.

Done.

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
File chrome/browser/ui/cocoa/one_click_signin_view_controller.h (right):

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_view_controller.h:41: -
(id)initWithNibName:(NSString*)nibName
On 2013/04/19 19:54:15, Alexei Svitkine wrote:
> Please document these params.

Done.

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_view_controller.h:45:
isSyncDialog:(bool)isSyncDialog
On 2013/04/19 19:54:15, Alexei Svitkine wrote:
> Use the Obj-C type BOOL (with values YES/NO) rather than the C++ type bool.

Done.

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
File chrome/browser/ui/cocoa/one_click_signin_view_controller.mm (right):

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_view_controller.mm:52: errorMessage_ =
base::SysUTF16ToNSString(errorMessage);
I have changed the parameter to NSString* as it's more Objective-C-ish, but
sadly, I have to leave in the length check, as the string can be not null but
still empty.

On 2013/04/19 19:54:15, Alexei Svitkine wrote:
> Make the ctor param type NSString* and pass in nil instead of std::string()
when
> you want to not have it, then you can change the [errorMessage_ length] != 0
> check to just errorMessage_.

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_view_controller.mm:61: if
(isSyncDialog_ && !startSyncCallback_.is_null()) {
Hmm, but you only DCHECK in the constructor, and this is called much later,
where I worry about it having been NULL'ed randomly...Too much worry?

On 2013/04/19 19:54:15, Alexei Svitkine wrote:
> If |isSyncDialog_| is YES, then you're already DCHECK'ing that the callback
> isn't NULL, so you don't need the second condition in the if.

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_view_controller.mm:148: // the
non-modal bubble already has a text content
On 2013/04/19 19:54:15, Alexei Svitkine wrote:
> Comments should be full sentences.

Done.

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_view_controller.mm:151: messageText =
l10n_util::GetNSStringWithFixup(IDS_ONE_CLICK_SIGNIN_DIALOG_MESSAGE);
On 2013/04/19 19:54:15, Alexei Svitkine wrote:
> Wrap this so it doesn't excede 80 chars.

Done.

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_view_controller.mm:158:
ui::ResourceBundle::SmallFont).GetNativeFont();
On 2013/04/19 19:54:15, Alexei Svitkine wrote:
> I suggest just having a fontSize local variable that's assigned differently
> based on the if - that way you don't have to repeat the wordy ResourceBundle
> call (which should also be good for binary size).

Done.

[Alexei Svitkine (slow), 2013-04-22 18:16:51]

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
File chrome/browser/ui/cocoa/one_click_signin_view_controller.mm (right):

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_view_controller.mm:61: if
(isSyncDialog_ && !startSyncCallback_.is_null()) {
On 2013/04/22 15:28:07, Monica Dinculescu wrote:
> Hmm, but you only DCHECK in the constructor, and this is called much later,
> where I worry about it having been NULL'ed randomly...Too much worry?

I guess you can add a DCHECK() here too, if you want - it's silly to have an if
guard here where you DCHECK on this earlier.

It's also strange to just do it here and not in one of the other places you use
the callback.

https://codereview.chromium.org/13845022/diff/17001/chrome/browser/ui/cocoa/o...
File chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h (right):

https://codereview.chromium.org/13845022/diff/17001/chrome/browser/ui/cocoa/o...
chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h:38:
errorMessage:(const string16&)errorMessage
Use an NSString* here too.

https://codereview.chromium.org/13845022/diff/17001/chrome/browser/ui/cocoa/o...
File chrome/browser/ui/cocoa/one_click_signin_view_controller.h (right):

https://codereview.chromium.org/13845022/diff/17001/chrome/browser/ui/cocoa/o...
chrome/browser/ui/cocoa/one_click_signin_view_controller.h:41: // |errorMessage|
is an alternate message that will be displayed in the
Add a sentence to describe the overall method.

https://codereview.chromium.org/13845022/diff/17001/chrome/browser/ui/cocoa/o...
chrome/browser/ui/cocoa/one_click_signin_view_controller.h:44: // Advanced links
and |callback| is called when the view is closing
Close the sentence - i.e. you need a period.

https://codereview.chromium.org/13845022/diff/17001/chrome/browser/ui/cocoa/o...
File chrome/browser/ui/cocoa/one_click_signin_view_controller.mm (right):

https://codereview.chromium.org/13845022/diff/17001/chrome/browser/ui/cocoa/o...
chrome/browser/ui/cocoa/one_click_signin_view_controller.mm:155: messageText =
[messageText stringByAppendingString:@" "];
What the reason for appending a space here?

[noms (inactive), 2013-04-23 18:52:48]

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
File chrome/browser/ui/cocoa/one_click_signin_view_controller.mm (right):

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_view_controller.mm:61: if
(isSyncDialog_ && !startSyncCallback_.is_null()) {
Ok, did some analysis: viewWillClose is called after the actions for ok/undo are
executed. These latter start sync, which also resets the syncCallback upon
completion. So by the time viewWillClose is called, if the syncCallback has
executed, it's now null. However, there could be an action where the view will
close without pressing ok/undo (at the moment this seems unlikely), in which
case viewWillClose needs to start sync. Since we can't remove the null check,
we'd have to remove the entire sync bit from viewWillClose, but I don't want
this to leave open an edge case where sync doesn't start correctly...Is this ok?

On 2013/04/22 18:16:51, Alexei Svitkine wrote:
> On 2013/04/22 15:28:07, Monica Dinculescu wrote:
> > Hmm, but you only DCHECK in the constructor, and this is called much later,
> > where I worry about it having been NULL'ed randomly...Too much worry?
> 
> I guess you can add a DCHECK() here too, if you want - it's silly to have an
if
> guard here where you DCHECK on this earlier.
> 
> It's also strange to just do it here and not in one of the other places you
use
> the callback.

https://codereview.chromium.org/13845022/diff/17001/chrome/browser/ui/cocoa/o...
File chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h (right):

https://codereview.chromium.org/13845022/diff/17001/chrome/browser/ui/cocoa/o...
chrome/browser/ui/cocoa/one_click_signin_bubble_controller.h:38:
errorMessage:(const string16&)errorMessage
On 2013/04/22 18:16:51, Alexei Svitkine wrote:
> Use an NSString* here too.

Done.

https://codereview.chromium.org/13845022/diff/17001/chrome/browser/ui/cocoa/o...
File chrome/browser/ui/cocoa/one_click_signin_view_controller.h (right):

https://codereview.chromium.org/13845022/diff/17001/chrome/browser/ui/cocoa/o...
chrome/browser/ui/cocoa/one_click_signin_view_controller.h:44: // Advanced links
and |callback| is called when the view is closing
On 2013/04/22 18:16:51, Alexei Svitkine wrote:
> Close the sentence - i.e. you need a period.

Done.

https://codereview.chromium.org/13845022/diff/17001/chrome/browser/ui/cocoa/o...
File chrome/browser/ui/cocoa/one_click_signin_view_controller.mm (right):

https://codereview.chromium.org/13845022/diff/17001/chrome/browser/ui/cocoa/o...
chrome/browser/ui/cocoa/one_click_signin_view_controller.mm:155: messageText =
[messageText stringByAppendingString:@" "];
In the modal dialog, the Learn More link is appended inline with the dialog
text. No space means it would be squished together after the period.

On 2013/04/22 18:16:51, Alexei Svitkine wrote:
> What the reason for appending a space here?

[Alexei Svitkine (slow), 2013-04-23 19:43:23]

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
File chrome/browser/ui/cocoa/one_click_signin_view_controller.mm (right):

https://codereview.chromium.org/13845022/diff/6002/chrome/browser/ui/cocoa/on...
chrome/browser/ui/cocoa/one_click_signin_view_controller.mm:61: if
(isSyncDialog_ && !startSyncCallback_.is_null()) {
On 2013/04/23 18:52:48, Monica Dinculescu wrote:
> Ok, did some analysis: viewWillClose is called after the actions for ok/undo
are
> executed. These latter start sync, which also resets the syncCallback upon
> completion. So by the time viewWillClose is called, if the syncCallback has
> executed, it's now null. However, there could be an action where the view will
> close without pressing ok/undo (at the moment this seems unlikely), in which
> case viewWillClose needs to start sync. Since we can't remove the null check,
> we'd have to remove the entire sync bit from viewWillClose, but I don't want
> this to leave open an edge case where sync doesn't start correctly...Is this
ok?
> 
> On 2013/04/22 18:16:51, Alexei Svitkine wrote:
> > On 2013/04/22 15:28:07, Monica Dinculescu wrote:
> > > Hmm, but you only DCHECK in the constructor, and this is called much
later,
> > > where I worry about it having been NULL'ed randomly...Too much worry?
> > 
> > I guess you can add a DCHECK() here too, if you want - it's silly to have an
> if
> > guard here where you DCHECK on this earlier.
> > 
> > It's also strange to just do it here and not in one of the other places you
> use
> > the callback.
> 

Okay, I understand the need for the NULL check given your explanation.

Please add a comment to explain this. Also, it would be good to find out what
this case is where viewWillClose will be called without buttons being clicked.
Is it when the window is just closed, for example? It would be good to mention
the specific cases explicitly in the comment.

https://codereview.chromium.org/13845022/diff/25001/chrome/browser/ui/cocoa/b...
File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right):

https://codereview.chromium.org/13845022/diff/25001/chrome/browser/ui/cocoa/b...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:497: error_message)
This should be indented 4 more.

https://codereview.chromium.org/13845022/diff/25001/chrome/browser/ui/cocoa/o...
File chrome/browser/ui/cocoa/one_click_signin_bubble_controller_unittest.mm
(left):

https://codereview.chromium.org/13845022/diff/25001/chrome/browser/ui/cocoa/o...
chrome/browser/ui/cocoa/one_click_signin_bubble_controller_unittest.mm:79:
TEST_F(OneClickSigninBubbleControllerTest, Advanced) {
Why is this test being deleted?

https://codereview.chromium.org/13845022/diff/25001/chrome/browser/ui/cocoa/o...
File chrome/browser/ui/cocoa/one_click_signin_view_controller.h (right):

https://codereview.chromium.org/13845022/diff/25001/chrome/browser/ui/cocoa/o...
chrome/browser/ui/cocoa/one_click_signin_view_controller.h:29: NSString*
errorMessage_;
This should be a scoped_nsobject.

[noms (inactive), 2013-04-24 14:49:29]

https://codereview.chromium.org/13845022/diff/25001/chrome/browser/ui/cocoa/b...
File chrome/browser/ui/cocoa/browser_window_cocoa.mm (right):

https://codereview.chromium.org/13845022/diff/25001/chrome/browser/ui/cocoa/b...
chrome/browser/ui/cocoa/browser_window_cocoa.mm:497: error_message)
On 2013/04/23 19:43:24, Alexei Svitkine wrote:
> This should be indented 4 more.

Done.

https://codereview.chromium.org/13845022/diff/25001/chrome/browser/ui/cocoa/o...
File chrome/browser/ui/cocoa/one_click_signin_bubble_controller_unittest.mm
(left):

https://codereview.chromium.org/13845022/diff/25001/chrome/browser/ui/cocoa/o...
chrome/browser/ui/cocoa/one_click_signin_bubble_controller_unittest.mm:79:
TEST_F(OneClickSigninBubbleControllerTest, Advanced) {
The new code for the Advanced link event handler opens a new tab, which isn't
possible in a unit test. I've added an entire class of browser tests to deal
with this.

On 2013/04/23 19:43:24, Alexei Svitkine wrote:
> Why is this test being deleted?

https://codereview.chromium.org/13845022/diff/25001/chrome/browser/ui/cocoa/o...
File chrome/browser/ui/cocoa/one_click_signin_view_controller.h (right):

https://codereview.chromium.org/13845022/diff/25001/chrome/browser/ui/cocoa/o...
chrome/browser/ui/cocoa/one_click_signin_view_controller.h:29: NSString*
errorMessage_;
On 2013/04/23 19:43:24, Alexei Svitkine wrote:
> This should be a scoped_nsobject.

Done.

[Alexei Svitkine (slow), 2013-04-24 15:26:27]

Awesome! Just a few more nits in your new file.

https://codereview.chromium.org/13845022/diff/33001/chrome/browser/ui/cocoa/o...
File chrome/browser/ui/cocoa/one_click_signin_bubble_controller_browsertest.mm
(right):

https://codereview.chromium.org/13845022/diff/33001/chrome/browser/ui/cocoa/o...
chrome/browser/ui/cocoa/one_click_signin_bubble_controller_browsertest.mm:18: :
InProcessBrowserTest(),
Nit: I don't think you need to explicitly call the parent ctor if it doesn't
take any arguments.

https://codereview.chromium.org/13845022/diff/33001/chrome/browser/ui/cocoa/o...
chrome/browser/ui/cocoa/one_click_signin_bubble_controller_browsertest.mm:44:
scoped_nsobject<OneClickSigninBubbleController> controller_;
Make all variables private and provide accessors to them, if you need to use
them from test cases.

https://codereview.chromium.org/13845022/diff/33001/chrome/browser/ui/cocoa/o...
chrome/browser/ui/cocoa/one_click_signin_bubble_controller_browsertest.mm:45:
OneClickSigninSyncStarter::StartSyncMode sync_mode_;
Are you using this anywhere?

https://codereview.chromium.org/13845022/diff/33001/chrome/browser/ui/cocoa/o...
chrome/browser/ui/cocoa/one_click_signin_bubble_controller_browsertest.mm:92:
clickedOnLink:nil
Nit: Align the :'s.

https://codereview.chromium.org/13845022/diff/33001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/13845022/diff/33001/chrome/chrome_tests.gypi#...
chrome/chrome_tests.gypi:1535:
'browser/ui/cocoa/one_click_signin_bubble_controller_browsertest.mm',
Nit: Should be in alphabetical order.

[noms (inactive), 2013-04-25 18:29:58]

https://codereview.chromium.org/13845022/diff/33001/chrome/browser/ui/cocoa/o...
File chrome/browser/ui/cocoa/one_click_signin_bubble_controller_browsertest.mm
(right):

https://codereview.chromium.org/13845022/diff/33001/chrome/browser/ui/cocoa/o...
chrome/browser/ui/cocoa/one_click_signin_bubble_controller_browsertest.mm:18: :
InProcessBrowserTest(),
On 2013/04/24 15:26:27, Alexei Svitkine wrote:
> Nit: I don't think you need to explicitly call the parent ctor if it doesn't
> take any arguments.

Done.

https://codereview.chromium.org/13845022/diff/33001/chrome/browser/ui/cocoa/o...
chrome/browser/ui/cocoa/one_click_signin_bubble_controller_browsertest.mm:45:
OneClickSigninSyncStarter::StartSyncMode sync_mode_;
On 2013/04/24 15:26:27, Alexei Svitkine wrote:
> Are you using this anywhere?

Done.

https://codereview.chromium.org/13845022/diff/33001/chrome/browser/ui/cocoa/o...
chrome/browser/ui/cocoa/one_click_signin_bubble_controller_browsertest.mm:92:
clickedOnLink:nil
On 2013/04/24 15:26:27, Alexei Svitkine wrote:
> Nit: Align the :'s.

Done.

https://codereview.chromium.org/13845022/diff/33001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/13845022/diff/33001/chrome/chrome_tests.gypi#...
chrome/chrome_tests.gypi:1535:
'browser/ui/cocoa/one_click_signin_bubble_controller_browsertest.mm',
On 2013/04/24 15:26:27, Alexei Svitkine wrote:
> Nit: Should be in alphabetical order.

Done.

[Alexei Svitkine (slow), 2013-04-25 18:32:51]

lgtm

[noms (inactive), 2013-04-25 18:50:29]

+nico for nibs owners:
chrome/app/nibs/OneClickSigninBubble.xib

[Nico, 2013-04-25 19:11:57]

lgtm stamp

asvitkine: Do you want to add yourself to chrome/app/nibs/OWNERS?

[commit-bot: I haz the power, 2013-05-01 20:38:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noms@chromium.org/13845022/74002

[commit-bot: I haz the power, 2013-05-01 21:02:26]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-01 21:05:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noms@chromium.org/13845022/74002

[commit-bot: I haz the power, 2013-05-01 21:14:48]

Sorry for I got bad news for ya.
Compile failed with a clobber build on android_clang_dbg.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-01 22:02:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noms@chromium.org/13845022/74002

[commit-bot: I haz the power, 2013-05-02 01:34:24]

Change committed as 197769