chrome/browser/ui/cocoa/one_click_signin_dialog_controller_browsertest.mm - Issue 13845022: Mac: Display a native bubble (instead of the JS one) after the web signin flow. (branched from http…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/one_click_signin_dialog_controller_browsertest.mm

Issue 13845022: Mac: Display a native bubble (instead of the JS one) after the web signin flow. (branched from http… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntpBubble

Patch Set: Ditto Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm ('k') | chrome/browser/ui/cocoa/one_click_signin_view_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/one_click_signin_dialog_controller_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/one_click_signin_dialog_controller_browsertest.mm b/chrome/browser/ui/cocoa/one_click_signin_dialog_controller_browsertest.mm

index 096a8f029d904b5c12d2e550a1ccfb4bc25b0e8e..f3a32a775369e06f857e7383d82123cf3bb776f4 100644

--- a/chrome/browser/ui/cocoa/one_click_signin_dialog_controller_browsertest.mm

+++ b/chrome/browser/ui/cocoa/one_click_signin_dialog_controller_browsertest.mm

@@ -14,8 +14,7 @@

class OneClickSigninDialogControllerTest : public InProcessBrowserTest {

public:

OneClickSigninDialogControllerTest()

- : InProcessBrowserTest(),

- controller_(NULL),

+ : controller_(NULL),

sync_mode_(OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS),

callback_count_(0) {

}