Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.cc

Issue 1374053002: Remove AboutToNavigateRenderFrame, issue custom notification for DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased, win test fix Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_ui_bindings.cc
diff --git a/chrome/browser/devtools/devtools_ui_bindings.cc b/chrome/browser/devtools/devtools_ui_bindings.cc
index 8ebae8cad50890e1fa0dec0ded36f41d4720d072..1bbd30eb6ab9ee1e42b0b2562523e0dd68fcde2f 100644
--- a/chrome/browser/devtools/devtools_ui_bindings.cc
+++ b/chrome/browser/devtools/devtools_ui_bindings.cc
@@ -300,11 +300,9 @@ class DevToolsUIBindings::FrontendWebContentsObserver
private:
// contents::WebContentsObserver:
void RenderProcessGone(base::TerminationStatus status) override;
- // TODO(creis): Replace with RenderFrameCreated when http://crbug.com/425397
- // is fixed. See also http://crbug.com/424641.
- void AboutToNavigateRenderFrame(
- content::RenderFrameHost* old_host,
- content::RenderFrameHost* new_host) override;
+ void DidStartNavigationToPendingEntry(
+ const GURL& url,
+ content::NavigationController::ReloadType reload_type) override;
void DocumentOnLoadCompletedInMainFrame() override;
void DidNavigateMainFrame(
const content::LoadCommittedDetails& details,
@@ -346,12 +344,11 @@ void DevToolsUIBindings::FrontendWebContentsObserver::RenderProcessGone(
}
void DevToolsUIBindings::FrontendWebContentsObserver::
- AboutToNavigateRenderFrame(content::RenderFrameHost* old_host,
- content::RenderFrameHost* new_host) {
- if (new_host->GetParent())
- return;
+ DidStartNavigationToPendingEntry(
+ const GURL& url,
+ content::NavigationController::ReloadType reload_type) {
devtools_bindings_->frontend_host_.reset(
- content::DevToolsFrontendHost::Create(new_host,
+ content::DevToolsFrontendHost::Create(web_contents()->GetMainFrame(),
devtools_bindings_));
}
« no previous file with comments | « no previous file | chrome/browser/ui/sync/one_click_signin_sync_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698