Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13713003: Remove all of WebCore/platform/mac which is not mentioned in WebCore.gypi. (Closed)

Created:
7 years, 8 months ago by eseidel
Modified:
7 years, 8 months ago
Reviewers:
Nico, abarth-chromium
CC:
blink-reviews, Steve Block
Visibility:
Public.

Description

Remove all of WebCore/platform/mac which is not mentioned in WebCore.gypi. R=abarth,thakis Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147590

Patch Set 1 #

Patch Set 2 : Added back a couple needed headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12367 lines) Patch
M Source/WebCore/loader/cache/MemoryCache.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D Source/WebCore/platform/PublicSuffix.h View 1 chunk +0 lines, -46 lines 0 comments Download
D Source/WebCore/platform/mac/ClipboardMac.h View 1 chunk +0 lines, -96 lines 0 comments Download
D Source/WebCore/platform/mac/ClipboardMac.mm View 1 chunk +0 lines, -437 lines 0 comments Download
D Source/WebCore/platform/mac/ContentFilterMac.mm View 1 chunk +0 lines, -87 lines 0 comments Download
D Source/WebCore/platform/mac/ContextMenuItemMac.mm View 1 chunk +0 lines, -192 lines 0 comments Download
D Source/WebCore/platform/mac/ContextMenuMac.mm View 1 chunk +0 lines, -113 lines 0 comments Download
D Source/WebCore/platform/mac/CursorMac.mm View 1 chunk +0 lines, -368 lines 0 comments Download
D Source/WebCore/platform/mac/DisplaySleepDisabler.h View 1 chunk +0 lines, -59 lines 0 comments Download
D Source/WebCore/platform/mac/DisplaySleepDisabler.cpp View 1 chunk +0 lines, -69 lines 0 comments Download
D Source/WebCore/platform/mac/DragDataMac.mm View 1 chunk +0 lines, -199 lines 0 comments Download
D Source/WebCore/platform/mac/DragImageMac.mm View 1 chunk +0 lines, -349 lines 0 comments Download
D Source/WebCore/platform/mac/EventLoopMac.mm View 1 chunk +0 lines, -42 lines 0 comments Download
D Source/WebCore/platform/mac/FileSystemMac.mm View 1 chunk +0 lines, -125 lines 0 comments Download
D Source/WebCore/platform/mac/HTMLConverter.h View 1 chunk +0 lines, -91 lines 0 comments Download
D Source/WebCore/platform/mac/HTMLConverter.mm View 1 chunk +0 lines, -1780 lines 0 comments Download
D Source/WebCore/platform/mac/KURLMac.mm View 1 chunk +0 lines, -92 lines 0 comments Download
D Source/WebCore/platform/mac/KeyEventMac.mm View 1 chunk +0 lines, -81 lines 0 comments Download
D Source/WebCore/platform/mac/Language.mm View 1 chunk +0 lines, -122 lines 0 comments Download
D Source/WebCore/platform/mac/LocalizedStringsMac.cpp View 1 chunk +0 lines, -59 lines 0 comments Download
D Source/WebCore/platform/mac/LoggingMac.mm View 1 chunk +0 lines, -83 lines 0 comments Download
D Source/WebCore/platform/mac/MIMETypeRegistryMac.mm View 1 chunk +0 lines, -67 lines 0 comments Download
D Source/WebCore/platform/mac/MemoryPressureHandlerMac.mm View 1 chunk +0 lines, -178 lines 0 comments Download
D Source/WebCore/platform/mac/PasteboardMac.mm View 1 chunk +0 lines, -587 lines 0 comments Download
D Source/WebCore/platform/mac/PlatformClockCA.h View 1 chunk +0 lines, -61 lines 0 comments Download
D Source/WebCore/platform/mac/PlatformClockCA.cpp View 1 chunk +0 lines, -122 lines 0 comments Download
D Source/WebCore/platform/mac/PlatformClockCM.h View 1 chunk +0 lines, -66 lines 0 comments Download
D Source/WebCore/platform/mac/PlatformClockCM.mm View 1 chunk +0 lines, -114 lines 0 comments Download
D Source/WebCore/platform/mac/PlatformEventFactoryMac.h View 1 chunk +0 lines, -61 lines 0 comments Download
D Source/WebCore/platform/mac/PlatformEventFactoryMac.mm View 1 chunk +0 lines, -539 lines 0 comments Download
D Source/WebCore/platform/mac/PlatformPasteboardMac.mm View 1 chunk +0 lines, -158 lines 0 comments Download
D Source/WebCore/platform/mac/PlatformScreenMac.mm View 1 chunk +0 lines, -106 lines 0 comments Download
D Source/WebCore/platform/mac/PlatformSpeechSynthesisMac.mm View 1 chunk +0 lines, -75 lines 0 comments Download
D Source/WebCore/platform/mac/PlatformSpeechSynthesizerMac.mm View 1 chunk +0 lines, -257 lines 0 comments Download
D Source/WebCore/platform/mac/PopupMenuMac.h View 1 chunk +0 lines, -58 lines 0 comments Download
D Source/WebCore/platform/mac/PopupMenuMac.mm View 1 chunk +0 lines, -235 lines 0 comments Download
D Source/WebCore/platform/mac/PublicSuffixMac.mm View 1 chunk +0 lines, -80 lines 0 comments Download
D Source/WebCore/platform/mac/RunLoopMac.mm View 1 chunk +0 lines, -74 lines 0 comments Download
D Source/WebCore/platform/mac/SSLKeyGeneratorMac.cpp View 1 chunk +0 lines, -66 lines 0 comments Download
D Source/WebCore/platform/mac/ScrollViewMac.mm View 1 chunk +0 lines, -227 lines 0 comments Download
D Source/WebCore/platform/mac/SearchPopupMenuMac.h View 1 chunk +0 lines, -44 lines 0 comments Download
D Source/WebCore/platform/mac/SearchPopupMenuMac.mm View 1 chunk +0 lines, -80 lines 0 comments Download
D Source/WebCore/platform/mac/SharedTimerMac.mm View 1 chunk +0 lines, -195 lines 0 comments Download
D Source/WebCore/platform/mac/SoftLinking.h View 1 chunk +0 lines, -175 lines 0 comments Download
D Source/WebCore/platform/mac/SoundMac.mm View 1 chunk +0 lines, -33 lines 0 comments Download
D Source/WebCore/platform/mac/SuddenTermination.mm View 1 chunk +0 lines, -45 lines 0 comments Download
D Source/WebCore/platform/mac/SystemTimeMac.cpp View 1 chunk +0 lines, -39 lines 0 comments Download
D Source/WebCore/platform/mac/SystemVersionMac.h View 1 chunk +0 lines, -29 lines 0 comments Download
D Source/WebCore/platform/mac/SystemVersionMac.mm View 1 chunk +0 lines, -74 lines 0 comments Download
D Source/WebCore/platform/mac/ThreadCheck.mm View 1 chunk +0 lines, -118 lines 0 comments Download
D Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.h View 1 chunk +0 lines, -42 lines 0 comments Download
D Source/WebCore/platform/mac/WebCoreFullScreenPlaceholderView.mm View 1 chunk +0 lines, -96 lines 0 comments Download
D Source/WebCore/platform/mac/WebCoreFullScreenWarningView.h View 1 chunk +0 lines, -41 lines 0 comments Download
D Source/WebCore/platform/mac/WebCoreFullScreenWarningView.mm View 1 chunk +0 lines, -108 lines 0 comments Download
D Source/WebCore/platform/mac/WebCoreFullScreenWindow.h View 1 chunk +0 lines, -36 lines 0 comments Download
D Source/WebCore/platform/mac/WebCoreFullScreenWindow.mm View 1 chunk +0 lines, -77 lines 0 comments Download
D Source/WebCore/platform/mac/WebCoreNSCellExtras.m View 1 chunk +0 lines, -46 lines 0 comments Download
D Source/WebCore/platform/mac/WebCoreNSStringExtras.h View 1 chunk +0 lines, -53 lines 0 comments Download
D Source/WebCore/platform/mac/WebCoreNSStringExtras.mm View 1 chunk +0 lines, -129 lines 0 comments Download
D Source/WebCore/platform/mac/WebCoreNSURLExtras.h View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/WebCore/platform/mac/WebCoreNSURLExtras.mm View 1 chunk +0 lines, -886 lines 0 comments Download
D Source/WebCore/platform/mac/WebCoreObjCExtras.h View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/WebCore/platform/mac/WebCoreObjCExtras.mm View 1 chunk +0 lines, -82 lines 0 comments Download
M Source/WebCore/platform/mac/WebCoreSystemInterface.mm View 1 chunk +0 lines, -4 lines 0 comments Download
D Source/WebCore/platform/mac/WebCoreView.h View 1 chunk +0 lines, -28 lines 0 comments Download
D Source/WebCore/platform/mac/WebCoreView.m View 1 chunk +0 lines, -65 lines 0 comments Download
D Source/WebCore/platform/mac/WebNSAttributedStringExtras.h View 1 chunk +0 lines, -30 lines 0 comments Download
D Source/WebCore/platform/mac/WebNSAttributedStringExtras.mm View 1 chunk +0 lines, -66 lines 0 comments Download
D Source/WebCore/platform/mac/WebVideoFullscreenController.h View 1 chunk +0 lines, -71 lines 0 comments Download
D Source/WebCore/platform/mac/WebVideoFullscreenController.mm View 1 chunk +0 lines, -556 lines 0 comments Download
D Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.h View 1 chunk +0 lines, -71 lines 0 comments Download
D Source/WebCore/platform/mac/WebVideoFullscreenHUDWindowController.mm View 1 chunk +0 lines, -678 lines 0 comments Download
D Source/WebCore/platform/mac/WebWindowAnimation.h View 1 chunk +0 lines, -59 lines 0 comments Download
D Source/WebCore/platform/mac/WebWindowAnimation.mm View 1 chunk +0 lines, -235 lines 0 comments Download
D Source/WebCore/platform/mac/WidgetMac.mm View 1 chunk +0 lines, -342 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
lgtm
7 years, 8 months ago (2013-04-05 07:05:39 UTC) #1
eseidel
7 years, 8 months ago (2013-04-05 07:35:28 UTC) #2
Message was sent while issue was closed. 
Committed patchset #2 manually as r147590 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698