Create metric_tool to deal with metric definitions

Create metric_tool to deal with metric definitions

Grep Python files in search of metric definitions and print
documentation when it exists.

This is essentially a way to work around the current limitations
of the ts_mon pipeline.

BUG=

Committed: https://chromium.googlesource.com/infra/infra/+/682af2dec12fa72c6eec1d9ab13d5526ad70d69a

[pgervais, 2015-09-25 00:16:28]

pgervais@chromium.org changed reviewers:
+ sergeyberezin@chromium.org

[pgervais, 2015-09-25 00:16:28]

ptal

[Sergey Berezin, 2015-09-25 00:31:28]

Overall seems good. If you want to keep this in infra.git, let's add some tests.

[pgervais, 2015-09-28 21:50:29]

Added tests and made the tool print undocumented metrics as well.

[Sergey Berezin, 2015-09-29 00:01:19]

LGTM + a few minor comments.

https://chromiumcodereview.appspot.com/1368583005/diff/20001/infra/tools/metr...
File infra/tools/metric_tool/__main__.py (right):

https://chromiumcodereview.appspot.com/1368583005/diff/20001/infra/tools/metr...
infra/tools/metric_tool/__main__.py:9: # This file is untested, keep as little
code as possible in there.
Consider adding a smoke test just to make sure the code runs.

https://chromiumcodereview.appspot.com/1368583005/diff/20001/infra/tools/metr...
File infra/tools/metric_tool/metric_tool.py (right):

https://chromiumcodereview.appspot.com/1368583005/diff/20001/infra/tools/metr...
infra/tools/metric_tool/metric_tool.py:16: 'FloatMetric', 'DistributionMetric',
nit: ideally, DistributionMetric shouldn't be used as is. But it still might
be...

https://chromiumcodereview.appspot.com/1368583005/diff/20001/infra/tools/metr...
File infra/tools/metric_tool/test/data/normal_case_2.py (right):

https://chromiumcodereview.appspot.com/1368583005/diff/20001/infra/tools/metr...
infra/tools/metric_tool/test/data/normal_case_2.py:20: description='metric3')
nit: is the weird indentation a part of the test?

https://chromiumcodereview.appspot.com/1368583005/diff/20001/infra/tools/metr...
infra/tools/metric_tool/test/data/normal_case_2.py:33: description='metric8')
nit: another weird indentation

https://chromiumcodereview.appspot.com/1368583005/diff/20001/infra/tools/metr...
File infra/tools/metric_tool/test/metric_tool_test.py (right):

https://chromiumcodereview.appspot.com/1368583005/diff/20001/infra/tools/metr...
infra/tools/metric_tool/test/metric_tool_test.py:50: self.assertTrue(desc is
None or name.endswith(desc))
Technically, if the function drops all metrics without descriptions, the test
would still pass.

https://chromiumcodereview.appspot.com/1368583005/diff/20001/infra/tools/metr...
infra/tools/metric_tool/test/metric_tool_test.py:75: # Sorry for the useless
name...
nit: remove the comment, it's useless :-)

[pgervais, 2015-09-30 00:09:38]

https://codereview.chromium.org/1368583005/diff/20001/infra/tools/metric_tool...
File infra/tools/metric_tool/metric_tool.py (right):

https://codereview.chromium.org/1368583005/diff/20001/infra/tools/metric_tool...
infra/tools/metric_tool/metric_tool.py:16: 'FloatMetric', 'DistributionMetric',
On 2015/09/29 00:01:18, Sergey Berezin wrote:
> nit: ideally, DistributionMetric shouldn't be used as is. But it still might
> be...

Removed

https://codereview.chromium.org/1368583005/diff/20001/infra/tools/metric_tool...
File infra/tools/metric_tool/test/data/normal_case_2.py (right):

https://codereview.chromium.org/1368583005/diff/20001/infra/tools/metric_tool...
infra/tools/metric_tool/test/data/normal_case_2.py:20: description='metric3')
On 2015/09/29 00:01:18, Sergey Berezin wrote:
> nit: is the weird indentation a part of the test?

Done.

https://codereview.chromium.org/1368583005/diff/20001/infra/tools/metric_tool...
infra/tools/metric_tool/test/data/normal_case_2.py:33: description='metric8')
On 2015/09/29 00:01:18, Sergey Berezin wrote:
> nit: another weird indentation

Done.

https://codereview.chromium.org/1368583005/diff/20001/infra/tools/metric_tool...
File infra/tools/metric_tool/test/metric_tool_test.py (right):

https://codereview.chromium.org/1368583005/diff/20001/infra/tools/metric_tool...
infra/tools/metric_tool/test/metric_tool_test.py:50: self.assertTrue(desc is
None or name.endswith(desc))
On 2015/09/29 00:01:18, Sergey Berezin wrote:
> Technically, if the function drops all metrics without descriptions, the test
> would still pass.

Good catch. Fixed.

https://codereview.chromium.org/1368583005/diff/20001/infra/tools/metric_tool...
infra/tools/metric_tool/test/metric_tool_test.py:75: # Sorry for the useless
name...
On 2015/09/29 00:01:18, Sergey Berezin wrote:
> nit: remove the comment, it's useless :-)

Done.

[pgervais, 2015-09-30 00:09:46]

The CQ bit was checked by pgervais@chromium.org

[pgervais, 2015-09-30 00:09:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyberezin@chromium.org
Link to the patchset: https://codereview.chromium.org/1368583005/#ps40001
(title: "More fixes")

[commit-bot: I haz the power, 2015-09-30 00:10:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1368583005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1368583005/40001

[commit-bot: I haz the power, 2015-09-30 00:15:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-30 00:15:17]

Try jobs failed on following builders:
  Infra Win Tester on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Infra%20Win%20Tester/bu...)

[pgervais, 2015-09-30 00:17:17]

The CQ bit was checked by pgervais@chromium.org

[pgervais, 2015-09-30 00:17:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyberezin@chromium.org
Link to the patchset: https://codereview.chromium.org/1368583005/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2015-09-30 00:17:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1368583005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1368583005/60001

[commit-bot: I haz the power, 2015-09-30 00:27:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-30 00:27:44]

Try jobs failed on following builders:
  Infra Win Tester on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Infra%20Win%20Tester/bu...)

[pgervais, 2015-09-30 16:53:30]

The CQ bit was checked by pgervais@chromium.org

[commit-bot: I haz the power, 2015-09-30 16:53:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1368583005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1368583005/60001

[commit-bot: I haz the power, 2015-09-30 16:55:30]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/682af2dec12fa72c6eec1d9ab13d5...