infra/tools/metric_tool/test/data/other_tests.py - Issue 1368583005: Create metric_tool to deal with metric definitions

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: infra/tools/metric_tool/test/data/other_tests.py

Issue 1368583005: Create metric_tool to deal with metric definitions (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Rebase Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2015 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 """This file is meant to exercise weird cases in metric_tool.py"""

	6

	7 import infra_libs

	8

	9 def nice_function():

	10 # Calling of function as an attribute which is not a *Metric()

	11 infra_libs.read_json_as_utf8()

	12

	13 # Wrong type passed to 'description'

	14 infra_libs.ts_mon.BooleanMetric('/my/metric', description=1)

	15

	16 def other_function():

	17 # Function call that is not a metric instantiation.

	18 nice_function()

OLD	NEW