Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 13652003: Update NaCl ARM build flags now that gcc used as default compiler. (Closed)

Created:
7 years, 8 months ago by Sam Clegg
Modified:
7 years, 8 months ago
CC:
chromium-reviews, Mark Seaborn, khim
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Update NaCl ARM build flags now that gcc used as default compiler. Second attempt at this change. The required a native_client change: https://codereview.chromium.org/12499011/ Thus this change also brings in NaCl changes from 11084:11126 inclusive. BUG=196627 TEST=run nacl brower tests one ARM linux Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192521

Patch Set 1 #

Total comments: 1

Patch Set 2 : remove dup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -69 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/download_nacl_toolchains.py View 1 1 chunk +9 lines, -10 lines 0 comments Download
M ppapi/native_client/native_client.gyp View 1 chunk +16 lines, -46 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/ppapi_untrusted.gyp View 2 chunks +3 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sam Clegg
This is the same change as https://codereview.chromium.org/13129002/ but with the download_toolchain fix to make sure ...
7 years, 8 months ago (2013-04-04 19:22:01 UTC) #1
dmichael (off chromium)
You can just TBR me when you're landing a change that I already LGTMed. Or ...
7 years, 8 months ago (2013-04-04 20:23:02 UTC) #2
Derek Schuff
lgtm, after fixing the duplicate https://codereview.chromium.org/13652003/diff/1/build/download_nacl_toolchains.py File build/download_nacl_toolchains.py (right): https://codereview.chromium.org/13652003/diff/1/build/download_nacl_toolchains.py#newcode64 build/download_nacl_toolchains.py:64: sys.exit(Main(sys.argv[1:])) duplicate?
7 years, 8 months ago (2013-04-04 20:36:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/13652003/19001
7 years, 8 months ago (2013-04-04 23:06:40 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-04 23:16:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/13652003/19001
7 years, 8 months ago (2013-04-05 00:44:40 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-05 07:19:48 UTC) #7
Message was sent while issue was closed.
Change committed as 192521

Powered by Google App Engine
This is Rietveld 408576698