Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2579)

Unified Diff: build/download_nacl_toolchains.py

Issue 13652003: Update NaCl ARM build flags now that gcc used as default compiler. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: remove dup Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | ppapi/native_client/native_client.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/download_nacl_toolchains.py
diff --git a/build/download_nacl_toolchains.py b/build/download_nacl_toolchains.py
index c2007d0f1038258af358413cf8a06e8e210445f7..3a4cb1b8bfaf08239f7ff348effb28d648e63627 100755
--- a/build/download_nacl_toolchains.py
+++ b/build/download_nacl_toolchains.py
@@ -29,32 +29,31 @@ def Main(args):
# TODO (robertm): Finish getting PNaCl ready for prime time.
# BUG:
# We remove this --optional-pnacl argument, and instead replace it with
- # --no-pnacl for most cases. However, if the bot name is the pnacl_sdk
+ # --no-pnacl for most cases. However, if the bot name is an sdk
# bot then we will go ahead and download it. This prevents increasing the
# gclient sync time for developers, or standard Chrome bots.
if '--optional-pnacl' in args:
args.remove('--optional-pnacl')
- # By default we don't use PNaCl toolchain yet, unless on ARM, where
- # there is no other toolchain to build untrusted code at the moment.
- # So analyze if we're building for ARM, or on SDK buildbot.
- # TODO(olonho): we need to invent more reliable way to get build
- # configuration info, to know if we're building for ARM.
use_pnacl = False
- if 'target_arch=arm' in os.environ.get('GYP_DEFINES', ''):
- use_pnacl = True
buildbot_name = os.environ.get('BUILDBOT_BUILDERNAME', '')
- if buildbot_name.find('pnacl') >= 0 and buildbot_name.find('sdk') >= 0:
+ if 'pnacl' in buildbot_name and 'sdk' in buildbot_name:
use_pnacl = True
if use_pnacl:
print '\n*** DOWNLOADING PNACL TOOLCHAIN ***\n'
else:
args.append('--no-pnacl')
+ # Only download the ARM gcc toolchain if we are building for ARM
+ # TODO(olonho): we need to invent more reliable way to get build
+ # configuration info, to know if we're building for ARM.
+ if 'target_arch=arm' in os.environ.get('GYP_DEFINES', ''):
+ args.append('--arm-untrusted')
+
# Append the name of the file to use as a version and hash source.
# NOTE: While not recommended, it is possible to redirect this file to
# a chrome location to avoid branching NaCl if just a toolchain needs
# to be bumped.
- args.append(os.path.join(nacl_dir,'TOOL_REVISIONS'))
+ args.append(os.path.join(nacl_dir, 'TOOL_REVISIONS'))
download_toolchains.main(args)
return 0
« no previous file with comments | « DEPS ('k') | ppapi/native_client/native_client.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698