Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2241)

Unified Diff: ppapi/native_client/native_client.gyp

Issue 13652003: Update NaCl ARM build flags now that gcc used as default compiler. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: remove dup Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/native_client/native_client.gyp
diff --git a/ppapi/native_client/native_client.gyp b/ppapi/native_client/native_client.gyp
index 825d1207b84bf4eff36d82d5e84205802abd0087..f6556315b5db08fbb283b31af1debf4a575ac513 100644
--- a/ppapi/native_client/native_client.gyp
+++ b/ppapi/native_client/native_client.gyp
@@ -114,54 +114,24 @@
'-lgio',
'-Wl,--end-group',
'-lm',
+ '-Wl,--section-start,.rodata=<(NACL_IRT_DATA_START)',
+ '-Wl,-Ttext-segment=<(NACL_IRT_TEXT_START)',
],
- # See http://code.google.com/p/nativeclient/issues/detail?id=2691.
- # The PNaCl linker (gold) does not implement the "-Ttext-segment"
- # option. However, with the linker for x86, the "-Ttext" option
- # does not affect the executable's base address.
- # TODO(olonho): simplify flags handling and avoid duplication
- # with NaCl logic.
'conditions': [
- ['target_arch!="arm"',
- {
- 'link_flags': [
- '-Wl,--section-start,.rodata=<(NACL_IRT_DATA_START)',
- '-Wl,-Ttext-segment=<(NACL_IRT_TEXT_START)',
- ]
- }, { # target_arch == "arm"
- # TODO(mcgrathr): This knowledge really belongs in
- # native_client/src/untrusted/irt/irt.gyp instead of here.
- # But that builds libirt_browser.a as bitcode, so a native
- # object does not fit happily there.
- 'sources': [
- '../../native_client/src/untrusted/irt/aeabi_read_tp.S',
- ],
- 'link_flags': [
- '-Wl,--section-start,.rodata=<(NACL_IRT_DATA_START)',
- '-Wl,-Ttext=<(NACL_IRT_TEXT_START)',
- '--pnacl-allow-native',
- '-arch', 'arm',
- '-Wt,-mtls-use-call',
- '-Wl,--pnacl-irt-link',
- ],
- },
- ],
- # untrusted.gypi and build_nexe.py currently build
- # both x86-32 and x86-64 whenever target_arch is some
- # flavor of x86. However, on non-windows platforms
- # we only need one architecture.
- ['OS!="win" and target_arch=="ia32"',
- {
- 'enable_x86_64': 0
- }
- ],
- ['OS!="win" and target_arch=="x64"',
- {
- 'enable_x86_32': 0
- }
- ]
- ],
- 'sources': [
+ # untrusted.gypi and build_nexe.py currently build
+ # both x86-32 and x86-64 whenever target_arch is some
+ # flavor of x86. However, on non-windows platforms
+ # we only need one architecture.
+ ['OS!="win" and target_arch=="ia32"',
+ {
+ 'enable_x86_64': 0
+ }
+ ],
+ ['OS!="win" and target_arch=="x64"',
+ {
+ 'enable_x86_32': 0
+ }
+ ]
],
'extra_args': [
'--strip-debug',
« no previous file with comments | « build/download_nacl_toolchains.py ('k') | ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698