Issue 13651002: [chromedriver] Fix 3 bugs with frame handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13651002: [chromedriver] Fix 3 bugs with frame handling. (Closed)

Created:
7 years, 8 months ago by kkania

Modified:
7 years, 8 months ago

Reviewers:
craigdh

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chromedriver] Fix 3 bugs with frame handling. -Track frame info for newly inserted nodes via DOM.childNodeInserted. -Update subframe execution context IDs. -Return NoSuchFrame if the frame doesn't have a execution context BUG=chromedriver:279 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192501

Patch Set 1 : . #

Patch Set 2 : . #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -4 lines)			Patch
M	chrome/test/chromedriver/chrome/dom_tracker.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/test/chromedriver/chrome/dom_tracker_unittest.cc	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	chrome/test/chromedriver/chrome/frame_tracker.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/chromedriver/chrome/frame_tracker_unittest.cc	View	1	2 chunks	+22 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

craigdh

On 2013/04/04 19:35:25, kkania wrote: > going ahead and adding one more small frame fix; ...

7 years, 8 months ago (2013-04-04 22:25:17 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/13651002/11001

7 years, 8 months ago (2013-04-04 22:49:30 UTC) #5

Message was sent while issue was closed.

Change committed as 192501

Expand Messages | Collapse Messages