Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Unified Diff: chrome/test/chromedriver/chrome/dom_tracker.cc

Issue 13651002: [chromedriver] Fix 3 bugs with frame handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/chromedriver/chrome/dom_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/dom_tracker.cc
diff --git a/chrome/test/chromedriver/chrome/dom_tracker.cc b/chrome/test/chromedriver/chrome/dom_tracker.cc
index 2531b85ac5bf56d9d1f1c8a2995c2756464dbd8a..3a73ec376784590155697fee6cd62d394211efab 100644
--- a/chrome/test/chromedriver/chrome/dom_tracker.cc
+++ b/chrome/test/chromedriver/chrome/dom_tracker.cc
@@ -48,6 +48,17 @@ void DomTracker::OnEvent(const std::string& method,
base::JSONWriter::Write(nodes, &json);
LOG(ERROR) << "DOM.setChildNodes has invalid 'nodes': " << json;
}
+ } else if (method == "DOM.childNodeInserted") {
+ const base::Value* node;
+ if (!params.Get("node", &node)) {
+ LOG(ERROR) << "DOM.childNodeInserted missing 'node'";
+ return;
+ }
+ if (!ProcessNode(node)) {
+ std::string json;
+ base::JSONWriter::Write(node, &json);
+ LOG(ERROR) << "DOM.childNodeInserted has invalid 'node': " << json;
+ }
} else if (method == "DOM.documentUpdated") {
node_to_frame_map_.clear();
base::DictionaryValue params;
« no previous file with comments | « no previous file | chrome/test/chromedriver/chrome/dom_tracker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698