Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: chrome/test/chromedriver/chrome/dom_tracker_unittest.cc

Issue 13651002: [chromedriver] Fix 3 bugs with frame handling. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/dom_tracker.cc ('k') | chrome/test/chromedriver/chrome/frame_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/dom_tracker_unittest.cc
diff --git a/chrome/test/chromedriver/chrome/dom_tracker_unittest.cc b/chrome/test/chromedriver/chrome/dom_tracker_unittest.cc
index 8a38e7f1301161ae696acfda7c1bb2f7f0b7e334..cd1c41b87163350a42851d0427d817b1d1960bc4 100644
--- a/chrome/test/chromedriver/chrome/dom_tracker_unittest.cc
+++ b/chrome/test/chromedriver/chrome/dom_tracker_unittest.cc
@@ -71,3 +71,22 @@ TEST(DomTracker, GetFrameIdForNode) {
ASSERT_TRUE(tracker.GetFrameIdForNode(102, &frame_id).IsError());
ASSERT_STREQ("DOM.getDocument", client.PopSentCommand().c_str());
}
+
+TEST(DomTracker, ChildNodeInserted) {
+ FakeDevToolsClient client;
+ DomTracker tracker(&client);
+ std::string frame_id;
+
+ base::DictionaryValue params;
+ params.Set("node", base::JSONReader::Read("{\"nodeId\":1}"));
+ tracker.OnEvent("DOM.childNodeInserted", params);
+ ASSERT_TRUE(tracker.GetFrameIdForNode(1, &frame_id).IsError());
+ ASSERT_TRUE(frame_id.empty());
+
+ params.Clear();
+ params.Set("node", base::JSONReader::Read(
+ "{\"nodeId\":2,\"frameId\":\"f\"}"));
+ tracker.OnEvent("DOM.childNodeInserted", params);
+ ASSERT_TRUE(tracker.GetFrameIdForNode(2, &frame_id).IsOk());
+ ASSERT_STREQ("f", frame_id.c_str());
+}
« no previous file with comments | « chrome/test/chromedriver/chrome/dom_tracker.cc ('k') | chrome/test/chromedriver/chrome/frame_tracker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698