DescriptionRevert 181390 "SPDY - implement greedy approach to read all the ..."
Revert 181637 "SPDY - Small bug fix for user after free. Will ..."
Revert 182012 "SPDY - Added unit tests for use after free of ..."
> SPDY - implement greedy approach to read all the data and process it
> from the ClientSocket until we block.
>
> This is more of a first cut at the greedy approach to see if it
> improves the performance on the mobile.
>
> spdy_session_test_util.* files have the common code between
> SpdySessionSpd2Test and SpdySessionSpd3Test. Will move other common
> code in a separate CL. Created this file to reduce errors and
> to avoid duplicating of code.
>
> R=willchan
> BUG=166958
> TEST=network unittests
>
> Review URL: https://chromiumcodereview.appspot.com/11644088
> SPDY - Small bug fix for user after free. Will revert the
> change asap.
>
> The change adds a scoped_refptr to SpdySession in DoLoop
> to clean up the state and to finish pending reads, in case
> SpdyFramer receives GOAway and closes all streams.
>
> DoReadComplete was holding the last reference before and
> DoLoop was accessing the object after DoReadComplete deleted
> the object at the end of the function.
>
> R=willchan@chromium.org
> BUG=175069
> TEST=network unit tests
> Review URL: https://codereview.chromium.org/12212102
> SPDY - Added unit tests for use after free of SpdySession
> and unit test to test yielding + async during Read.
>
> A test that crashes when scoped_refptr to SpdySession deleted
> from DoLoop.
>
> Added the following test per rch to test interactions of
> yielding + async during Read.
>
> Do the following MockReads and verify all the data is consumed
> and SpdySession has yielded during Read.
> SYNCHRONOUS 8K
> SYNCHRONOUS 8K
> SYNCHRONOUS 8K
> SYNCHRONOUS 2K
> ASYNC 8K
> SYNCHRONOUS 8K
> SYNCHRONOUS 8K
> SYNCHRONOUS 8K
> SYNCHRONOUS 2K
>
> R=rch@chromium.org
> BUG=175574, 166958
> TEST=net unit tests
>
> Review URL: https://chromiumcodereview.appspot.com/12207122
TBR=rtenneti@chromium.org, rch@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192313
Patch Set 1 #
Messages
Total messages: 5 (0 generated)
|