Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 13608003: Revert 181390 "SPDY - implement greedy approach to read all the ..." (Closed)

Created:
7 years, 8 months ago by ramant (doing other things)
Modified:
7 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ryan Sleevi, jar (doing other things)
Visibility:
Public.

Description

Revert 181390 "SPDY - implement greedy approach to read all the ..." Revert 181637 "SPDY - Small bug fix for user after free. Will ..." Revert 182012 "SPDY - Added unit tests for use after free of ..." > SPDY - implement greedy approach to read all the data and process it > from the ClientSocket until we block. > > This is more of a first cut at the greedy approach to see if it > improves the performance on the mobile. > > spdy_session_test_util.* files have the common code between > SpdySessionSpd2Test and SpdySessionSpd3Test. Will move other common > code in a separate CL. Created this file to reduce errors and > to avoid duplicating of code. > > R=willchan > BUG=166958 > TEST=network unittests > > Review URL: https://chromiumcodereview.appspot.com/11644088 > SPDY - Small bug fix for user after free. Will revert the > change asap. > > The change adds a scoped_refptr to SpdySession in DoLoop > to clean up the state and to finish pending reads, in case > SpdyFramer receives GOAway and closes all streams. > > DoReadComplete was holding the last reference before and > DoLoop was accessing the object after DoReadComplete deleted > the object at the end of the function. > > R=willchan@chromium.org > BUG=175069 > TEST=network unit tests > Review URL: https://codereview.chromium.org/12212102 > SPDY - Added unit tests for use after free of SpdySession > and unit test to test yielding + async during Read. > > A test that crashes when scoped_refptr to SpdySession deleted > from DoLoop. > > Added the following test per rch to test interactions of > yielding + async during Read. > > Do the following MockReads and verify all the data is consumed > and SpdySession has yielded during Read. > SYNCHRONOUS 8K > SYNCHRONOUS 8K > SYNCHRONOUS 8K > SYNCHRONOUS 2K > ASYNC 8K > SYNCHRONOUS 8K > SYNCHRONOUS 8K > SYNCHRONOUS 8K > SYNCHRONOUS 2K > > R=rch@chromium.org > BUG=175574, 166958 > TEST=net unit tests > > Review URL: https://chromiumcodereview.appspot.com/12207122 TBR=rtenneti@chromium.org, rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192313

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -937 lines) Patch
M net/net.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M net/spdy/spdy_session.h View 7 chunks +11 lines, -34 lines 0 comments Download
M net/spdy/spdy_session.cc View 12 chunks +76 lines, -91 lines 0 comments Download
M net/spdy/spdy_session_spdy2_unittest.cc View 2 chunks +0 lines, -375 lines 0 comments Download
M net/spdy/spdy_session_spdy3_unittest.cc View 2 chunks +0 lines, -351 lines 0 comments Download
M net/spdy/spdy_session_test_util.h View 1 chunk +0 lines, -46 lines 0 comments Download
M net/spdy/spdy_session_test_util.cc View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/13608003/1
7 years, 8 months ago (2013-04-04 01:45:06 UTC) #1
ramant (doing other things)
Hi Ryan, Have reverted the following three patches (all related to greedy changes) to see ...
7 years, 8 months ago (2013-04-04 01:53:31 UTC) #2
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-04 01:54:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/13608003/1
7 years, 8 months ago (2013-04-04 02:22:40 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-04 12:12:39 UTC) #5
Message was sent while issue was closed.
Change committed as 192313

Powered by Google App Engine
This is Rietveld 408576698